8000 [#410] Evolve options API without bumping major version every time by ruspl-afed · Pull Request #414 · eclipse-cdt/cdt-lsp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[#410] Evolve options API without bumping major version every time #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2025
Merged

[#410] Evolve options API without bumping major version every time #414

merged 1 commit into from
Feb 5, 2025

Conversation

ruspl-afed
Copy link
Member
  • make provider interfaces less domain specific but more stable
  • improve API and implementation

@ruspl-afed ruspl-afed requested a review from ghentschke February 3, 2025 20:26
@ruspl-afed ruspl-afed force-pushed the 410 branch 3 times, most recently from 9bda0dc to 859b052 Compare February 3, 2025 20:58
@ruspl-afed ruspl-afed changed the title [#410] Evolve options API without bumping major version every time WIP: [#410] Evolve options API without bumping major version every time Feb 3, 2025
@ruspl-afed ruspl-afed changed the title WIP: [#410] Evolve options API without bumping major version every time [#410] Evolve options API without bumping major version every time Feb 4, 2025
@ruspl-afed
Copy link
Member Author

There were test failures but now everything is green. Please have a look @ghentschke

@ghentschke
Copy link
Contributor
ghentschke commented Feb 4, 2025 •
edited
Loading

This look pretty good. But the restore defaults button in the preference page doesn't work. It just resets the current changes but not to the defaults.

@ruspl-afed
Copy link
Member Author

This look pretty good. But the restore defaults button in the preference page doesn't work. It just 10000 resets the current changes but not to the defaults.

Thank you! I'll check on my side and will let you know

@ruspl-afed
[eclipse-cdt#410] Evolve options API without bumping major version ev…
66416c1 
…ery time

* make provider interfaces less domain specific but more stable
* improve API and implementation
@ruspl-afed
Copy link
Member Author

@ghentschke I did a fix for ConfigurationPage#performDefaults
now "Restore Defaults" button works good for me.

@ghentschke
Copy link
Contributor

@ghentschke I did a fix for ConfigurationPage#performDefaults now "Restore Defaults" button works good for me.

Great. I'll test it in the evening.

ghentschke
ghentschke approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor
@ghentschke ghentschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ruspl-afed Thank you!!!

@ghentschke ghentschke merged commit d88501e into eclipse-cdt:main Feb 5, 2025
3 checks passed
@ruspl-afed ruspl-afed deleted the 410 branch February 5, 2025 20:25
jonahgraham
jonahgraham reviewed Feb 18, 2025
View reviewed changes
bundles/org.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/clangd/ClangdOptionsDefaults.java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghentschke / @ruspl-afed

This interface was removed here, but it is still referenced in the declarative part of the example to show how to override preference defaults. See

cdt-lsp/examples/org.eclipse.cdt.lsp.examples.preferences/OSGI-INF/org.eclipse.cdt.lsp.examples.preferences.MyClangdOptionsDefaults.xml

Line 5 in 9ee279c

<provide interface="org.eclipse.cdt.lsp.clangd.ClangdOptionsDefaults"/>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving to #426

@jonahgraham jonahgraham mentioned this pull request Feb 18, 2025
Closed
jonahgraham
jonahgraham reviewed Feb 18, 2025
View reviewed changes
Copy link
Member
@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have raised #427 as I think this change looses the ability for extenders to pick up new options.

@jonahgraham jonahgraham added this to the 3.0.0 milestone Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahgraham jonahgraham jonahgraham left review comments

@ghentschke ghentschke ghentschke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ruspl-afed @ghentschke @jonahgraham
0