8000 [#422] reset-to-default only preferences used on page by ghentschke · Pull Request #423 · eclipse-cdt/cdt-lsp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[#422] reset-to-default only preferences used on page #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 17, 2025

Conversation

ghentschke
Copy link
Contributor

fixes #422

@ghentschke
Copy link
Contributor Author
ghentschke commented Feb 17, 2025

I'll merge the ClangdContentAssistPreferences into the ClangdPreferences, because a separation is not needed anymore with this change.

Copy link
Member
@ruspl-afed ruspl-afed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for fixing this defect @ghentschke !

@ghentschke ghentschke merged commit f1c5507 into eclipse-cdt:main Feb 17, 2025
3 checks passed
@ghentschke ghentschke deleted the fix-422 branch February 17, 2025 19:32
@jonahgraham jonahgraham added this to the 3.0.0 milestone Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore defaults on Save Actions preference page resets settings on Editor (LSP) preference page as well
3 participants
0