8000 [#120] Clangd options in preference/project properties not changeable by ruspl-afed · Pull Request #126 · eclipse-cdt/cdt-lsp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[#120] Clangd options in preference/project properties not changeable #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

ruspl-afed
Copy link
Member

Provide explicit default scope

@ruspl-afed ruspl-afed requested a review from ghentschke June 14, 2023 15:20
@ruspl-afed
Copy link
Member Author

PreferenceService is doing something strange, when asked to get value from DefaultScope, so I switched to manual retrieval.

Copy link
Contributor
@ghentschke ghentschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I tested it on my windows machine. Project an WS defaults will be set as expected.
Thank you @ruspl-afed !

@ruspl-afed ruspl-afed merged commit 22b3a89 into eclipse-cdt:master Jun 14, 2023
@jonahgraham jonahgraham added this to the 1.0.0 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0