8000 Repository should have dedicated target definition #34 by ruspl-afed · Pull Request #35 · eclipse-cdt/cdt-lsp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Repository should have dedicated target definition #34 #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

ruspl-afed
Copy link
Member

Added releng/org.eclipse.cdt.lsp.target
Renamed root module to "org.eclipse.cdt.lsp.root" for consistency

@jonahgraham jonahgraham requested a review from chrismathis March 9, 2023 17:06
Copy link
Contributor
@chrismathis chrismathis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

As of now the pom.xml in org.eclipse.cdt.lsp.target would not be necessary and could be removed.

Added releng/org.eclipse.cdt.lsp.target
Renamed root module to "org.eclipse.cdt.lsp.root" for consistency

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
@ruspl-afed
Copy link
Member Author

As of now the pom.xml in org.eclipse.cdt.lsp.target would not be necessary and could be removed.

Great comment, thank you! Unnecessary pom.xml has been removed.

@ghentschke ghentschke merged commit 130296d into eclipse-cdt:master Mar 13, 2023
@ruspl-afed ruspl-afed deleted the 34 branch June 3, 2023 07:26
@jonahgraham jonahgraham added this to the 1.0.0 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0