8000 Add context menu entries "toggle breakpoint" and "enable/disable breakpoint" by travkin79 · Pull Request #367 · eclipse-cdt/cdt-lsp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add context menu entries "toggle breakpoint" and "enable/disable breakpoint" #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2024
Merged

Add context menu entries "toggle breakpoint" and "enable/disable breakpoint" #367

merged 2 commits into from
Sep 3, 2024

Conversation

travkin79
Copy link
Contributor

This PR adds ruler context menu entries to the CDT LSP editor for adding / removing a breakpoint (toggle breakpoint) and for enabling / disabling an existing breakpoint (see screenshot).

image

@travkin79 travkin79 force-pushed the patch-toggle-breakpoint branch from 7eca382 to c23d1e5 Compare August 30, 2024 15:23
@travkin79
Copy link
Contributor Author

Hi all,
I#m not familiar with the license check workflow, it fails for some reason for my PR. What does it check and how could I solve the issue for my PR? @ghentschke, could you help me here?

Besides, I had to adapt the path in the workflow's yaml file to get the license check running again.

@ghentschke
Copy link
Contributor

I#m not familiar with the license check workflow, it fails for some reason for my PR. What does it check and how could I solve the issue for my PR? @ghentschke, could you help me here?

I am not very familiar with this check as well. IMO it should check 3rd party licenses, but I am not sure. How do you found out that you have to change it to eclipse-dash? Maybe they've changed that. The license check seems to be somewhat flaky. Sometimes it works and sometimes not. Maybe @ruspl-afed or @jonahgraham can tell more.

@ghentschke
Copy link
Contributor

Thanks for the PR by the way. I'll try to test it unitl tomorrrow.

@travkin79
Copy link
Contributor Author

Hi @ghentschke,
Thank you for lo 8000 oking into this.

How do you found out that you have to change it to eclipse-dash?

I checked where the referenced yaml file comes from and found out that the file's path was different to that used in CDT LSP. In the dash licenses repo they refer to the file like that:

uses: eclipse-dash/dash-licenses/.github/workflows/mavenLicenseCheck.yml@master

@travkin79 travkin79 force-pushed the patch-toggle-breakpoint branch from dbe7d79 to 1537da6 Compare September 2, 2024 15:24
@ghentschke ghentschke merged commit 2502e53 into eclipse-cdt:master Sep 3, 2024
2 of 3 checks passed
@ghentschke
Copy link
Contributor

@travkin79 Thank you!

@travkin79
Copy link
Contributor Author

Thank you for reviewing and merging, @ghentschke.

@jonahgraham jonahgraham added this to the 3.0.0 milestone Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@travkin79 @ghentschke @jonahgraham
0