fix LS restart after exception #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to a change in LSP4E the restart of a LS, after an exception occurred during the start of the LS, is not possible anymore. This will be fixed.
ruspl-afed
reviewed
Sep 5, 2024
| /** | ||
| * Get active language servers | ||
| * @return Stream of LanguageServerWrapper | ||
| */ | ||
| public static Stream<LanguageServerWrapper> getLanguageServers() { |
There was a problem hiding this comment.
Missed this earlier, but Stream in public signature is not so cool, mostly because of the Stream state-full nature.
I don't believe that we can have any performance impact if we switch public methods to any collection.
For private method Stream is fine
|
Thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to this LSP4E change 1044 in LSP4E the restart of a LS, after an exception occurred during the start of the LS, is not possible anymore. This will be fixed.