-
Notifications
You must be signed in to change notification settings - Fork 214
Make CDT LSP editor more visible and easier to onboard in CDT 12 #968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
editor
The CDT C/C++, Assembly, Makefile and other editors provided by CDT
noteworthy
Pull requests and fixed issues that should be highlighted to users
Milestone
Comments
jonahgraham
added a commit
to jonahgraham/cdt
that referenced
this issue
Feb 16, 2025
jonahgraham
added a commit
to jonahgraham/eclipse-cdt-lsp
that referenced
this issue
Feb 17, 2025
Contribute a banner to the CEditor and CLspEditor to promote the new C/C++ editing experience based on LSP. The banner in CEditor enables a quick switch to the LSP editor, and in the CLspEditor it enables a quick switch back to the traditional CEditor. If the editor is open on a specific project and that project has project specific preferences for prefer_lsp, instead of automatically changing the setting, the property page is opened. TODO: - [ ] Externalize strings (and change problem severity back to warning) - [ ] Add preference to disable the banners in the editors - [ ] New help page and update TRY_LSP_HELP_PATH - [ ] Fix background re-opened editors after restart Requires eclipse-cdt/cdt#1088 Fixes eclipse-cdt/cdt#968
jonahgraham
added a commit
to jonahgraham/eclipse-cdt-lsp
that referenced
this issue
Feb 17, 2025
Contribute a banner to the CEditor and CLspEditor to promote the new C/C++ editing experience based on LSP. The banner in CEditor enables a quick switch to the LSP editor:  And in the CLspEditor it enables a quick switch back to the traditional CEditor.  If there is no project specific setting for `prefer_lsp` a quick confirmation dialog is displayed with options for help and feedback:  and the other way:  If the editor is open on a specific project and that project has project specific preferences for `prefer_lsp`, instead of automatically changing the setting, the property page is opened:  A notification is also displayed to the user offering more information and access to the preferences.  TODO: - [ ] Externalize strings (and change problem severity back to warning) - [ ] Add preference to disable the banners in the editors and connect the close banner to it. - [ ] If ConfigurationVisibility.showPreferLsp() returns false the banner won't be shown - [ ] New help page and update TRY_LSP_HELP_PATH - [ ] Fix background re-opened editors after restart. The non-activated editors are not saving their setting fully, so after reopening an error editor appears if it becomes activated Requires eclipse-cdt/cdt#1088 Fixes eclipse-cdt/cdt#968
This comment has been minimized.
This comment has been minimized.
jonahgraham
added a commit
to jonahgraham/eclipse-cdt-lsp
that referenced
this issue
Feb 18, 2025
Contribute a banner to the CEditor and CLspEditor to promote the new C/C++ editing experience based on LSP. The banner in CEditor enables a quick switch to the LSP editor:  And in the CLspEditor it enables a quick switch back to the traditional CEditor.  If there is no project specific setting for `prefer_lsp` a quick confirmation dialog is displayed with options for help and feedback:  and the other way:  If the editor is open on a specific project and that project has project specific preferences for `prefer_lsp`, instead of automatically changing the setting, the property page is opened:  A notification is also displayed to the user offering more information and access to the preferences.  TODO: - [ ] Externalize strings (and change problem severity back to warning) - [ ] Add preference to disable the banners in the editors and connect the close banner to it. - [ ] If ConfigurationVisibility.showPreferLsp() returns false the banner won't be shown - [ ] New help page and update TRY_LSP_HELP_PATH - [ ] Fix background re-opened editors after restart. The non-activated editors are not saving their setting fully, so after reopening an error editor appears if it becomes activated Requires eclipse-cdt/cdt#1088 Fixes eclipse-cdt/cdt#968
jonahgraham
added a commit
to jonahgraham/eclipse-cdt-lsp
that referenced
this issue
Feb 19, 2025
Contribute a banner to the CEditor and CLspEditor to promote the new C/C++ editing experience based on LSP. The banner in CEditor enables a quick switch to the LSP editor:  And in the CLspEditor it enables a quick switch back to the traditional CEditor.  If there is no project specific setting for `prefer_lsp` a quick confirmation dialog is displayed with options for help and feedback:  and the other way:  If the editor is open on a specific project and that project has project specific preferences for `prefer_lsp`, instead of automatically changing the setting, the property page is opened:  A notification is also displayed to the user offering more information and access to the preferences.  Fixes eclipse-cdt/cdt#968
jonahgraham
added a commit
to jonahgraham/eclipse-cdt-lsp
that referenced
this issue
Feb 19, 2025
Contribute a banner to the CEditor and CLspEditor to promote the new C/C++ editing experience based on LSP. The banner in CEditor enables a quick switch to the LSP editor:  And in the CLspEditor it enables a quick switch back to the traditional CEditor.  If there is no project specific setting for `prefer_lsp` a quick confirmation dialog is displayed with options for help and feedback:  and the other way:  If the editor is open on a specific project and that project has project specific preferences for `prefer_lsp`, instead of automatically changing the setting, the property page is opened:  A notification is also displayed to the user for a short while after the editors are re-opening offering more information and access to the preferences.  A notification is also displayed when closing the banner allowing the user easy access to disable opening the banner on new editors  Finally a new preference is available:  Fixes eclipse-cdt/cdt#968
jonahgraham
added a commit
to jonahgraham/eclipse-cdt-lsp
that referenced
this issue
Feb 19, 2025
Contribute a banner to the CEditor and CLspEditor to promote the new C/C++ editing experience based on LSP. The banner in CEditor enables a quick switch to the LSP editor:  And in the CLspEditor it enables a quick switch back to the traditional CEditor.  If there is no project specific setting for `prefer_lsp` a quick confirmation dialog is displayed with options for help and feedback:  and the other way:  If the editor is open on a specific project and that project has project specific preferences for `prefer_lsp`, instead of automatically changing the setting, the property page is opened:  A notification is also displayed to the user for a short while after the editors are re-opening offering more information and access to the preferences.  A notification is also displayed when closing the banner allowing the user easy access to disable opening the banner on new editors  Finally a new preference is available:  Fixes eclipse-cdt/cdt#968
jonahgraham
added a commit
to jonahgraham/eclipse-cdt-lsp
that referenced
this issue
Feb 19, 2025
Contribute a banner to the CEditor and CLspEditor to promote the new C/C++ editing experience based on LSP. The banner in CEditor enables a quick switch to the LSP editor:  And in the CLspEditor it enables a quick switch back to the traditional CEditor.  If there is no project specific setting for `prefer_lsp` a quick confirmation dialog is displayed with options for help and feedback:  and the other way:  If the editor is open on a specific project and that project has project specific preferences for `prefer_lsp`, instead of automatically changing the setting, the property page is opened:  A notification is also displayed to the user for a short while after the editors are re-opening offering more information and access to the preferences.  A notification is also displayed when closing the banner allowing the user easy access to disable opening the banner on new editors  Finally a new preference is available:  Fixes eclipse-cdt/cdt#968
jonahgraham
added a commit
to eclipse-cdt/cdt-lsp
that referenced
this issue
Feb 19, 2025
Contribute a banner to the CEditor and CLspEditor to promote the new C/C++ editing experience based on LSP. The banner in CEditor enables a quick switch to the LSP editor:  And in the CLspEditor it enables a quick switch back to the traditional CEditor.  If there is no project specific setting for `prefer_lsp` a quick confirmation dialog is displayed with options for help and feedback:  and the other way:  If the editor is open on a specific project and that project has project specific preferences for `prefer_lsp`, instead of automatically changing the setting, the property page is opened:  A notification is also displayed to the user for a short while after the editors are re-opening offering more information and access to the preferences.  A notification is also displayed when closing the banner allowing the user easy access to disable opening the banner on new editors  Finally a new preference is available:  Fixes eclipse-cdt/cdt#968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
editor
The CDT C/C++, Assembly, Makefile and other editors provided by CDT
noteworthy
Pull requests and fixed issues that should be highlighted to users
Uh oh!
There was an error while loading. Please reload this page.
The goal is for CDT users to have a way to easily try out the CDT-LSP feature and start to transition their workflows to the long term CDT implementation.
Make CDT LSP visible in the following ways:
More details on 1 and 2:
Contribute a banner to the CEditor and CLspEditor to promote the new C/C++ editing experience based on LSP. The banner in CEditor enables a quick switch to the LSP editor:
And in the CLspEditor it enables a quick switch back to the traditional CEditor.
If there is no project specific setting for
prefer_lsp
a quick confirmation dialog is displayed with options for help and feedback:and the other way:
If the editor is open on a specific project and that project has project specific preferences for
prefer_lsp
, instead of automatically changing the setting, the property page is opened:A notification (typically in the bottom right of the IDE) is also displayed to the user offering more information and access to the preferences.
In dark mode the banner looks like this:
And the notification (typically in the bottom right of the IDE) looks like this:
The text was updated successfully, but these errors were encountered: