[csharp] add a callback-based ServiceClient API and a corresponding C# sample (2) #2199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirror samples aligned slightly
Peguen
8000
reviewed
Jun 11, 2025
| @@ -112,7 +116,20 @@ Iterate through all responses and print them. | |||
| } | |||
| else | |||
| { | |||
| Console.WriteLine("Method blocking call failed."); | |||
| Console.WriteLine("Method call with reponse failed."); | |||
There was a problem hiding this comment.
Will fix this 😀
Peguen
approved these changes
Jun 11, 2025
Peguen
pushed a commit
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new, callback-based variant of the service client call (CallWithCallback) alongside the existing CallWithResponse. It also adds or updates C# sample code to demonstrate the new API.
API Changes
ServiceClient::CallWithCallback(String^ methodName, array<Byte>^ request, ResponseCallback^ callback, int timeoutMs)to the C# wrapper.Sample Added