Update RELEASE.md #1132
Open
Update RELEASE.md #1132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove instruction to remove website stage from Jenkinsfile Signed-off-by: Max Kasperowski <Eddykasp@users.noreply.github.com>
Signed-off-by: Max Kasperowski <Eddykasp@users.noreply.github.com>
Because it doesn't do anything and probably never did. The Jenkins build uses the Jenkinsfile defined on the master branch for builds on any branch. So modifying the file only on the branch doesn't actually prevent the website from being built. |
|
Maybe we jsut need a variable to build the website. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove instruction to remove website stage from Jenkinsfile.
It turns out Jenkins always uses the Jenkinsfile from the master branch, so removing the call on the release branch doesn't even have any effect.
This PR serves as a discussion starting point for how we would like to handle this in the future.