[25] JavaSearchBugs16Tests.testAIOOBEForRecordClassGh790() throws AssertionError #4095
+24
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that
8000
reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AssertionError + boldly reduce split package from source & binary versions of the same module to just one constituent. Fixes eclipse-jdt#3976
|
This change is a mere band-aid to avoid creation of an unwanted SplitPackageBinding, by reducing it to one of its constituents. I don't even want to think about what happens downstream with this arbitrarily chosen PlainPackageBinding. The question is not, whether the fix is correct (it is not), but rather: how much should we care about the initial situation in the first place? How much do we want to invest in its solution? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3976