Identify MutableCallSite for guards based on known object index
#7774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzongaro
reviewed
Jun 10, 2025
There was a problem hiding this comment.
I just happened upon a call to heuristicTrace in TR_InlinerBase::createVirtualGuard that uses the %p format specifier for the _mutableCallSiteObject field of TR_VirtualGuardSelection. I think that will need to be updated.
|
I just tripped across another minor issue. One of the constructors for |
...instead of based on reference location.
|
Updated the two additional places identified in review |
|
Jenkins build all< 8000 /p> |
|
It looks like porttest has seen a number of recent failures on osx_x86-64 recently. I think that failure is unrelated to this change. |
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instead of based on reference location.