8000 Update version of Azure Windows client to 2025 by jdekonin · Pull Request #7802 · eclipse-omr/omr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update version of Azure Windows client to 2025 #7802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

Update version of Azure Windows client to 2025 #7802

merged 1 commit into from
Jun 18, 2025

Conversation

jdekonin
Copy link
Contributor
  • Windows 2019 is unsupported by June 30

@jdekonin jdekonin marked this pull request as ready for review June 17, 2025 13:49
@jdekonin
Copy link
Contributor Author

Pulled details from this site:
https://github.com/actions/runner-images/blob/main/images/windows/Windows2025-Readme.md#visual-studio-enterprise-2022

@0xdaryl
Copy link
Contributor
0xdaryl commented Jun 18, 2025

Jenkins build win

@0xdaryl 0xdaryl self-assigned this Jun 18, 2025
0xdaryl
0xdaryl requested changes Jun 18, 2025
View reviewed changes
Copy link
Contributor
@0xdaryl 0xdaryl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you correct the spelling of "version" in your commit and PR titles please?

azure-pipelines.yml
set PATH=C:\Program Files (x86)\Windows Kits\10\bin\10.0.16299.0\x64;%PATH%
cmake .. -G "Visual Studio 16 2019" -A x64 -C../cmake/caches/Windows.cmake .. -DOMR_DDR=0 -DOMR_TEST_COMPILER=ON -DOMR_JITBUILDER_TEST=ON
set PATH=C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64;%PATH%
cmake .. -G "Visual Studio 17 2022" -A x64 -C../cmake/caches/Windows.cmake .. -DOMR_DDR=0 -DOMR_TEST_COMPILER=ON -DOMR_JITBUILDER_TEST=ON
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your commit title says "2025" but this line says "2022". Can you explain please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's the Windows version that is 2025, not the compiler.

@jdekonin
Update version of Azure Windows client to 2025
52f2a72 
* Windows 2019 is unsupported by June 30

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
@jdekonin jdekonin changed the title Update verison of Azure Windows client to 2025 Update version of Azure Windows client to 2025 Jun 18, 2025
@jdekonin
Copy link
Contributor Author

I didn't even notice the spelling mistake. :) Fixed

btw, the PR build doesn't actually test the change. That ran on a real machine.

@0xdaryl 0xdaryl added the ci label Jun 18, 2025
@0xdaryl 0xdaryl merged commit 97ec921 into eclipse-omr:master Jun 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xdaryl 0xdaryl 0xdaryl approved these changes

Assignees

@0xdaryl 0xdaryl

Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdekonin @0xdaryl
0