8000 Add Guards to the OffHeap-exclusive Code for vectorizedMismatch Transformer by luke-li-2003 · Pull Request #22037 · eclipse-openj9/openj9 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Guards to the OffHeap-exclusive Code for vectorizedMismatch Transformer #22037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

Add Guards to the OffHeap-exclusive Code for vectorizedMismatch Transformer #22037

merged 1 commit into from
Jun 4, 2025

Conversation

luke-li-2003
Copy link
Contributor

Add "if defined(J9VM_GC_SPARSE_HEAP_ALLOCATION)" guard to the recognized call transformer for vectorizedMismatch.

@luke-li-2003
Copy link
Contributor Author

FYI @r30shah @hzongaro

r30shah
r30shah approved these changes Jun 4, 2025
View reviewed changes
Copy link
Contributor
@r30shah r30shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Can you shorten the commit title to fit within 70 chars (If it is not).

@luke-li-2003 luke-li-2003 force-pushed the OffHeapVectorizedMismatchFix branch from 333ab6e to 9bff846 Compare June 4, 2025 15:29
@luke-li-2003
Copy link
Contributor Author

Updated title

@r30shah
Copy link
Contributor
r30shah commented Jun 4, 2025

jenkins compile amac jdk21

keithc-ca
keithc-ca reviewed Jun 4, 2025
View reviewed changes
@keithc-ca
Copy link
Contributor

Jenkins compile win32 jdk8

@keithc-ca keithc-ca mentioned this pull request Jun 4, 2025
Merged
@keithc-ca
Copy link
Contributor

It seems we need both this and #22030 to fix 32-bit builds. I'll merge #22030 and then start a new build.

@luke-li-2003 Please correct the comments as requested.

@keithc-ca
Copy link
Contributor

Jenkins compile win32 jdk8

keithc-ca
keithc-ca requested changes Jun 4, 2025
View reviewed changes
Copy link
Contributor
@keithc-ca keithc-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the commit message so lines in the body are no longer than 72 characters each.

@luke-li-2003
Add Guards to the vectorizedMismatch Transformer
310b85d 
Add "if defined(J9VM_GC_SPARSE_HEAP_ALLOCATION)"
guard to the recognized call transformer for
vectorizedMismatch's offheap-exclusive code.

Signed-off-by: Luke Li <luke.li@ibm.com>
@luke-li-2003 luke-li-2003 force-pushed the OffHeapVectorizedMismatchFix branch from 9bff846 to 310b85d Compare June 4, 2025 17:30
@luke-li-2003
Copy link
Contributor Author

The commit message has been updated.

@keithc-ca
Copy link
Contributor

For the record, the build passed: https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/7593.

@keithc-ca keithc-ca merged commit 8da8ef9 into eclipse-openj9:master Jun 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes

@r30shah r30shah r30shah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luke-li-2003 @r30shah @keithc-ca
0