Observe-Composite - Add integration tests #1063
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernard31
reviewed
Aug 2, 2021
There was a problem hiding this comment.
I think Tests readability could be improved here.
Ideally, the test should be understandable just by reading the test code without reading methods called. (I know it's not so easy and probably Leshan Tests code base doesn't always respect this 😬 )
My remarks below are just example which should be applied to all tests.
Another point, the code looks different than other integrations tests. In a general way I feel having "a code which is pretty much written in a same way" makes the whole code base easier to read. But I can understand if there is some part of the code you prefer to write in another way.
...n-tests/src/test/java/org/eclipse/leshan/integration/tests/observe/ObserveCompositeTest.java
Outdated
Show resolved
Hide resolved
...n-tests/src/test/java/org/eclipse/leshan/integration/tests/observe/ObserveCompositeTest.java
Outdated
Show resolved
Hide resolved
...n-tests/src/test/java/org/eclipse/leshan/integration/tests/observe/ObserveCompositeTest.java
Outdated
Show resolved
Hide resolved
...n-tests/src/test/java/org/eclipse/leshan/integration/tests/observe/ObserveCompositeTest.java
Outdated
Show resolved
Hide resolved
...n-tests/src/test/java/org/eclipse/leshan/integration/tests/observe/ObserveCompositeTest.java
Outdated
Show resolved
Hide resolved
Michal-Wadowski
pushed a commit
to Przem83/leshan
that referenced
this pull request
Aug 4, 2021
5c087ab to
36f90b9
Compare
added 12 commits
August 4, 2021 13:51
…ervation whenever is possible
Michal-Wadowski
pushed a commit
to Przem83/leshan
that referenced
this pull request
Aug 5, 2021
36f90b9 to
0669847
Compare
0669847 to
6c94e66
Compare
sbernard31
added a commit
that referenced
this pull request
Aug 19, 2021
|
Integrated in #1083 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial implementation of #1034