8000 SecurityMode: Add missing "Certificate mode with EST" (4) by dachaac · Pull Request #860 · eclipse-leshan/leshan · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

SecurityMode: Add missing "Certificate mode with EST" (4) #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2020
Merged

SecurityMode: Add missing "Certificate mode with EST" (4) #860

merged 1 commit into from
Jul 9, 2020

Conversation

dachaac
Copy link
Contributor
@dachaac dachaac commented Jul 8, 2020

This adds missing EST security mode enum value.

Now the list should be complete vs. specification.

This change relates to: #859

Signed-off-by: Vesa Jääskeläinen dachaac@gmail.com

@dachaac
SecurityMode: Add missing "Certificate mode with EST" (4)
ffce274 
Signed-off-by: Vesa Jääskeläinen <dachaac@gmail.com>
@sbernard31
Copy link
Contributor

I don't want to cause you extra work on re-creating 2.0.x branch so that you might receive some contributions for that -- I don't personally see that model viable contributing method. I feel better to have volatile working branch for a feature and then just rebasing periodically with master to receive new changes from there.

Just to let you know, I will try to release the 1.1 soon and I will create the official new 2.0.x/master branch.
Do you want I create you a dedicate branch for EST ? name : est_v11 ? (feel free to propose a better name ?)

@dachaac
Copy link
Contributor Author
dachaac commented Jul 8, 2020

I have my working branch in my fork:
https://github.com/dachaac/leshan/tree/est-support

I like to keep work-in-progress stuff in my fork and only integrate tidied up stuff. So no need to create a specific branch at this time. Let's see how it goes when we progress further.

This particular small change can go also with current version of master as it should not have any effect for anything else. But if you are about to make release feel free to wait with this.

@sbernard31 sbernard31 merged commit 054d305 into eclipse-leshan:master Jul 9, 2020
@sbernard31
Copy link
Contributor
sbernard31 commented Jul 9, 2020 •
edited
Loading

Now master is the 2.0.0 version which aims LWM2M 1.1, you should not be annoyed by revapi anymore, tell me if this is not case.
(By the way, I'm back on Wednesday 15th)

@dachaac dachaac deleted the est-add-security-mode branch August 4, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dachaac @sbernard31
0