8000 Add symbol tags as proposed for LSP specification (e.g. visibility tags, static, abstract, etc.) #977 by travkin79 · Pull Request #1149 · eclipse-lsp4e/lsp4e · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add symbol tags as proposed for LSP specification (e.g. visibility tags, static, abstract, etc.) #977 #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Add symbol tags as proposed for LSP specification (e.g. visibility tags, static, abstract, etc.) #977 #1149

wants to merge 19 commits into from
+608 −55

Conversation

travkin79
Copy link
Contributor
@travkin79 travkin79 commented Nov 22, 2024 •
edited
Loading

Start using new symbol tags as proposed in my microsoft/language-server-protocol#2003, for example, adding private, package, protected, and public visibility tags as well as tags like static, final, abstract, read-only, nullable and non-null. Our motivation comes from our wish to add visibility and other symbol details to the outline view (see discussion #977), but maybe also to the call hierarchy and to the type hierarchy or to other related features / LSP operations.

The PR on the LSP specification requires at least one implementation in a language server and / or a client. We plan to finish a first language server implementation in clangd [1] [2] and a first client implementation in LSP4J, LSP4E, and CDT LSP (which is using clangd).

See microsoft/language-server-protocol#2003
and llvm/llvm-project#113669
and eclipse-lsp4j/lsp4j#856

@rubenporras
Copy link
Contributor

This would be great it the LSP gets improved and a new version in released.

@travkin79
Rename a method and a variable
52d8d90
@travkin79
Extract method
b35a717
@travkin79
Extract method
2ac2449
@travkin79
Replace magic numbers
448f847
@travkin79
Combine severity and visibility overlays in outline view
bfcd1da 
Caching has still to be done
@travkin79
Use LSP4J 0.23.0
4ab10e0
@travkin79
Add symbol tag list to text document client capabilities and to
c601d62 
workspace client capabilities
@travkin79
Add overlays for additional symbol tags like static, abstract, final...
08c32fa
@travkin79
Add deprecation underlay symbol to outline view
2dad09a
@travkin79
Add "virtual" overlay icon
8a8a3f9
@travkin79
Adapt constructor object image to use a "C" overlay
b847b63 
The overlay is taken from JDT because of visual consistency.
Since there is no constructor symbol tag, but a symbol kind,
we use a work-around for that case when calculating overlays.
@travkin79
Add caching for overlay images and dispose them
9cb489d
@travkin79
First test cases to check symbol tag access
21f1b11
@travkin79
Add first test cases for LSP4E images
89dbd05
@travkin79 travkin79 mentioned this pull request Dec 5, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@travkin79 @rubenporras
0