[Fix #114] Add leak suspect retained heap top consumers #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Grigorenko <kevin.grigorenko@us.ibm.com>
|
@jasonk000 or @krumts: if one of you can please review when you have a chance, thanks! |
jasonk000
requested changes
May 13, 2025
Comment on lines
638
to
652
| Long sumHeapSize = sumHeapSizes.get(name); | ||
| if (sumHeapSize == null) | ||
| { | ||
| sumHeapSize = 0L; | ||
| } | ||
| sumHeapSize += snapshot.getHeapSize(objectId); | ||
| sumHeapSizes.put(name, sumHeapSize); | ||
|
|
||
| Integer count = counts.get(name); | ||
| if (count == null) | ||
| { | ||
| count = 0; | ||
| } | ||
| count++; | ||
| counts.put(name, count); |
There was a problem hiding this comment.
could be simplified
IObject object = snapshot.getObject(objectId);
String name = snapshot.isClass(objectId)
? ((IClass) object).getName()
: object.getClazz().getName();
sumHeapSizes.merge(name, snapshot.getHeapSize(objectId), Long::sum);
counts.merge(name, 1, Integer::sum);
| StringBuilder result = new StringBuilder(); | ||
| List<Entry<String, Long>> list = new ArrayList<>(sumHeapSizes.entrySet()); | ||
| list.sort((e1, e2) -> e2.getValue().compareTo(e1.getValue())); | ||
| List<Entry<String, Long>> finalList = list.subList(0, Math.min(list.size(), topItems)); |
There was a problem hiding this comment.
8000
I think this might be a slow way to sort for large counts - not sure how significant, what about something like a PriorityQueue to do the top-N sort? Probably not a huge deal.
| entry.getKey(), count, bytesFormatter.format(entry.getValue()))); | ||
| } | ||
| } | ||
| return HTMLUtils.escapeText(result.toString()); |
There was a problem hiding this comment.
I don't think we want all of this escaped, otherwise I see <..> etc in the output.
There was a problem hiding this comment.
Oops. I added escaping to fix some tests (classes with < and > in them) but then I forgot to run it again visually to see this.
Signed-off-by: Kevin Grigorenko <kevin.grigorenko@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #114, add a new second sentence (in bold below) that lists up to the top 3 consumers of the suspect's retained heap; for example: