10000 add encodeBuiltinType and encodeBuiltinTypeArray to UaEncoder interface by vpriscan · Pull Request #1463 · eclipse-milo/milo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add encodeBuiltinType and encodeBuiltinTypeArray to UaEncoder interface #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 1.0
Choose a base branch
from
Open

add encodeBuiltinType and encodeBuiltinTypeArray to UaEncoder interface #1463

wants to merge 1 commit into from

Conversation

vpriscan
Copy link

  • added common encodeBuiltinType and encodeBuiltinTypeArray to UaEncoder interface

  • aligning implementations in OpcUaJsonEncoder, OpcUaXmlEncoder and OpcUaBinaryEncoder

@vpriscan
add encodeBuiltinType and encodeBuiltinTypeArray to UaEncoder interface
8470c6c 
Signed-off-by: Vedran Prišćan <vedranpriscan95@gmail.com>
@kevinherron
Copy link
Contributor

I'm not really sure about these changes.

We didn't discuss this at any point, so I'm not sure why they're necessary at all. It's also odd that they are only for the encoder and not for the decoder as well?

I'm not keen on making API changes with 1.0 releasing this week.

@vpriscan
Copy link
Author
vpriscan commented May 19, 2025 •
edited
Loading

@kevinherron
In our software that uses Milo, we have value:Object and dataType:OpcUaDataType variables.
We want to encode this Object value with UaEncoder (json, xml or binary),
but all encodeBuiltin* functions that accept Object value are all private in UaEncoder implementations.
To avoid having to re-implement those functions (large switch-cases), it would be highly useful to move them to UaEncoder interface, or at least make them public in each implementation.

Equivalent would also be useful for UaDecoder as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vpriscan @kevinherron
0