8000 Feature Request: JSON Parser by alexandruiulian10 · Pull Request #822 · eclipse-score/score · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feature Request: JSON Parser #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Feature Request: JSON Parser #822

wants to merge 9 commits into from

Conversation

alexandruiulian10
Copy link
Contributor

Provides a proposal for a safe JSON parser feature.

@github-actions GitHub Actions
Copy link
github-actions bot commented Mar 31, 2025 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
INFO: Invocation ID: 62a09ee5-9071-436d-8e1f-6338083f0669
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/score/score/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/score/score/BUILD
INFO: Elapsed time: 4.964s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

simon-acc
simon-acc reviewed Mar 31, 2025
View reviewed changes
@alexandruiulian10 alexandruiulian10 force-pushed the json_feature_request branch 2 times, most recently from 2fb2df2 to 29b929c Compare April 1, 2025 12:37
rattenking52
rattenking52 suggested changes Apr 1, 2025
View reviewed changes
masc2023
masc2023 reviewed Apr 14, 2025
View reviewed changes
docs/features/communication/json/index.rst Outdated
Security Impact
===============

The module will likely work with input and output streams.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so what is the impact? Access Control needed?, please set also tag security to yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For access control and manipulation prevention (e.g. dm-verity) the hosting process and system configuration need to take care of it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then may add this as assumption of use in the feature request, otherwise it get lost, by the way, this is more a component_request as part of feature:baselib

@ramceb ramceb moved this to In Progress in Feature Requests Apr 14, 2025
rattenking52
rattenking52 suggested changes May 5, 2025
View reviewed changes
8000
@github-actions GitHub Actions
Copy link
github-actions bot commented May 7, 2025

The created documentation from the pull request is available at: docu-html

@alexandruiulian10 alexandruiulian10 force-pushed the json_feature_request branch 4 times, most recently from 5c9e3a9 to 70d0134 Compare May 9, 2025 13:58
alexandruiulian10 and others added 7 commits May 9, 2025 17:05
@alexandruiulian10
json-lib: JSON Feature Proposal
fd2cadf 
Signed-off-by: Alexandru Iulian <iulian.alexandru@continental-corporation.com>
@alexandruiulian10
json-lib: Fix typo in /docs/features/communication/json/index.rst
adf23df 
Signed-off-by: Alexandru Iulian <iulian.alexandru@continental-corporation.com>
@alexandruiulian10 @rattenking52
json-lib: Rephrase JSON parser requirements to be more generic.
008bb9b 
Co-authored-by: rattenking52 <acc.rattenking52@icloud.com>
Signed-off-by: Alexandru Iulian <iulian.alexandru@continental-corporation.com>
@alexandruiulian10
json-lib: Move JSON Parser feature request to baselibs folder
ebf2209 
Signed-off-by: Alexandru Iulian <iulian.alexandru@continental-corporation.com>
@alexandruiulian10 @rattenking52
json-lib: Rephrase some descriptions to be consistent with requirements
fd85fb6 
Co-authored-by: rattenking52 <acc.rattenking52@icloud.com>
Signed-off-by: Alexandru Iulian <iulian.alexandru@continental-corporation.com>
@alexandruiulian10
json-lib: Remove unneeded linkage in JSON parser requrements
6295864 
Signed-off-by: Alexandru Iulian <iulian.alexandru@continental-corporation.com>
@alexandruiulian10 @rattenking52
json-lib: Rename JSON Parser to JSON-Library
0684f44 
Co-authored-by: rattenking52 <acc.rattenking52@icloud.com>
Signed-off-by: Alexandru Iulian <iulian.alexandru@continental-corporation.com>
lammjo
lammjo reviewed May 15, 2025
View reviewed changes
alexandruiulian10
alexandruiulian10 commented May 15, 2025
View reviewed changes
@alexandruiulian10 @lammjo
json-lib: Rename requirement to stkh_req__communication__json_library
70b96a9 
Co-authored-by: Jonas Lammers <161199397+lammjo@users.noreply.github.com>
Signed-off-by: Alexandru Iulian <iulian.alexandru@continental-corporation.com>
masc2023
masc2023 reviewed May 15, 2025
View reviewed changes
docs/features/baselibs/json/index.rst Outdated
:id: doc__json
:status: valid
:safety: ASIL_B
:tags: contribution_request, feature_request
Copy link
Contributor
@masc2023 masc2023 May 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contribution_request is deprecated, shall be removed, further this is more a component_request for the baselib (feature)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the JSON lib should be a component request. It also means that this file has to follow the https://eclipse-score.github.io/score/main/process/process_areas/change_management/guidance/change_management_component_template.html I.e. Feature flag section is not needed for a component.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated that tag to component_request and removed the Feature flag section in the last commit

masc2023
masc2023 reviewed May 15, 2025
View reviewed changes
docs/features/baselibs/json/requirements/index.rst
:satisfies: stkh_req__communication__json_library
:status: valid

The JSON library shall support safe communication up to ASIL-B.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so why not link to that requirement stkh_req__communication__safe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stkh_req__communication__safe is ASIL-D, while this feature is meant to go only up to ASIL-B

masc2023
masc2023 reviewed May 15, 2025
View reviewed changes
docs/requirements/stakeholder/index.rst
:rationale: tbd
:status: valid

The software platform shall provide a JSON-Library with parsing functionality.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this no derive from stkh_req__functional_req__safe_config?

@alexandruiulian10
json-lib: Remove Feature flag section and correct deprecated flag
08ea684 
Signed-off-by: Alexandru Iulian <iulian.alexandru@continental-corporation.com>
@qor-lb qor-lb linked an issue May 19, 2025 that may be closed by this pull request
Feature request for qualified json-parser #757
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4og 4og 4og left review comments

@masc2023 masc2023 masc2023 left review comments

@lammjo lammjo lammjo left review comments

@simon-acc simon-acc simon-acc left review comments

@mishu-dev mishu-dev mishu-dev left review comments

@rattenking52 rattenking52 rattenking52 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community:architecture feature_request
Projects
Feature Requests
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request for qualified json-parser
8 participants
@alexandruiulian10 @4og @rattenking52 @masc2023 @lammjo @simon-acc @mishu-dev @antonkri
0