8000 Add a negative requirement on darkest dark 2024.4.0.202412101111 by merks · Pull Request #312 · eclipse-packaging/packages · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add a negative requirement on darkest dark 2024.4.0.202412101111 #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

merks
Copy link
Contributor
@merks merks commented May 22, 2025
  • Also switch back to building against staging.

#310

@akurtakov
Copy link
Contributor

This would stop everyone having darkest dark from updating to June release, right ? Is there a way to force uninstall of it instead.

@merks
Copy link
Contributor Author
merks commented May 22, 2025

I need to test, but you can see how the remediation suggested uninstalling the Oomph feature:

#310 (comment)

It might well be possible to use an Oomph p2 director task to uninstall it too, which could be another button. But I kind of doubt the people who have this installed will want to uninstall it...

It seems in everyone's best interest, including and maybe especially Genuitec, to fix the problem, in which case there will be a newer version available during update...

@jonahgraham
Copy link
Contributor

This doesn't actually work for upgrading from 2025-03 with dark mode installed. What it does is causes everything except the EPP to update. Doing a check for updates shows this screen showing no indication of an error

image

Pressing back does show the error:

image

So this solution does prevent installs, it doesn't solve the upgrade problem.

@merks
Copy link
Contributor Author
merks commented May 22, 2025

I was just in the middle of writing the following when you posted...

I have a bad feeling now that this won't really work as hoped because I think it will still possible to update just the platform:

image

One might argue this should be done by SWT itself, because that's where the incompatibility lies.

https://github.com/eclipse-platform/eclipse.platform.swt/blob/master/bundles/org.eclipse.swt/META-INF/p2.inf

@merks
Copy link
Contributor Author
merks commented May 22, 2025

I think that no matter what we do in EPP, we cannot prevent the platform from updating given its a root install feature. So I will close this.

@merks merks closed this May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0