8000 Quick fix added for invalid characters in MANIFEST header by nburnwal09 · Pull Request #1625 · eclipse-pde/eclipse.pde · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Quick fix added for invalid characters in MANIFEST header #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Quick fix added for invalid characters in MANIFEST header #1625

wants to merge 2 commits into from

Conversation

nburnwal09
Copy link

This is to provide quick fix for invalid header name in MANIFEST.MF
It will provide fix by removing all the invalid characters (characters other than alpha numeric characters, '-' and '_')
for eg. in the below image, added a space after 'Require-Bundle' header
the added quick fix label is 'Remove invalid characters from header'. Once user clicks on 'Finish', it updates the header

image

Attaching another example
image

@github-actions GitHub Actions
Copy link
github-actions bot commented Feb 21, 2025 •
edited
Loading

Test Results

  510 files   -   255    510 suites   - 255   43m 22s ⏱️ - 10m 8s
3 611 tests ±    0  3 535 ✅ ±    0   76 💤 ± 0  0 ❌ ±0 
7 222 runs   - 3 611  7 069 ✅  - 3 533  153 💤  - 78  0 ❌ ±0 

Results for commit d126552. ± Comparison against base commit 59e5453.

♻️ This comment has been updated with latest results.

@iloveeclipse
Copy link
Member

invalid header name

You probably mean attribute? See official wording at java.util.jar.Manifest.
If so, please change the wording overall - e.g. "Remove invalid characters from attribute name" etc.

@laeubi
Copy link
Contributor
laeubi commented Feb 21, 2025 •
edited
Loading

The OSGi speci always uses Bundle Headers as wording.

https://docs.osgi.org/reference/bundle-headers.html

Even Orcale name things in the main section "Header":

https://docs.oracle.com/javase/tutorial/deployment/jar/defman.html

These lines show that a manifest's entries take the form of "header: value" pairs. The name of a header is separated from its value by a colon. The default manifest conforms to version 1.0 of the manifest specification and was created by the 1.7.0_06 version of the JDK

So I think talking about "attributes" would be highly confusing.

@nburnwal09
Copy link
Author
nburnwal09 commented Feb 24, 2025 •
edited
Loading

As far as I have understood, the work 'attribute' would mean both, the "key: value" pair. But I have provided fix for removing invalid characters only from key(Header part).
So, have labeled it as 'Remove invalid characters from header'
Kindly confirm on this, and if it is okay, could you please approve this PR?
@laeubi

@laeubi
Copy link
Contributor
laeubi commented Feb 24, 2025

The Jar Specification explicitly allows both values:

information contained within the manifest file and signature files is represented as so-called "name: value" pairs inspired by the RFC822 standard. We also call these pairs headers or attributes.
Groups of name-value pairs are known as a "section"

So I think both can be used but "Header" is much more commonly understood.

@nburnwal09
Copy link
Author

@HannesWell
Can you please review this PR.

@HannesWell
Copy link
Member

Can you please review this PR.

Yes, I'll try all your open PRs and answer your questions in the next days. Sorry for the delay, it has been a busy time.

@nburnwal09
Copy link
Author

@HannesWell
Could you please check and review the PR's.

@nburnwal09 nburnwal09 force-pushed the invalid_header_QuickFix branch from 34cea75 to cc1c664 Compare May 12, 2025 09:48
@HannesWell
Copy link
Member

Could you please check and review the PR's.

Sorry, same as before. I try my best to review it as soon as possible.

@nburnwal09 nburnwal09 force-pushed the invalid_header_QuickFix branch from cc1c664 to 7966728 Compare May 27, 2025 10:21
@eclipse-pde-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch 
From 6e969d559e9eb50799a230a74f1b993e818341a2 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Thu, 5 Jun 2025 08:40:14 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
index 0d96f8a730..61b5e3c6e3 100644
--- a/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.core; singleton:=true
-Bundle-Version: 3.20.200.qualifier
+Bundle-Version: 3.20.300.qualifier
 Bundle-Activator: org.eclipse.pde.internal.core.PDECore
 Bundle-Vendor: %provider-name
 Bundle-Localization: plugin
diff --git a/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
index 645e581c4d..69ac002d3d 100644
--- a/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.ui; singleton:=true
-Bundle-Version: 3.16.100.qualifier
+Bundle-Version: 3.16.200.qualifier
 Bundle-Activator: org.eclipse.pde.internal.ui.PDEPlugin
 Bundle-Vendor: %provider-name
 Bundle-Localization: plugin
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

@merks
Copy link
Contributor
merks commented Jun 9, 2025

We can't incorporate merge commits. Best to force push a rebased commit.

@noopur2507 noopur2507 force-pushed the invalid_header_QuickFix branch from e2189e8 to d126552 Compare June 9, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nburnwal09 @iloveeclipse @laeubi @HannesWell @eclipse-pde-bot @merks
0