Refactor cloe-launch #201
Merged
Refactor cloe-launch #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clonker
reviewed
Dec 7, 2023
There was a problem hiding this comment.
- there is a funny mix between os.path and pathlib within this pr and the module in general, i think it is worth to clean that up a bit
- i feel like there was perhaps one file duplicated?
- unsure about platform dependence and what is the desired outcome here
- generally i think if you have a public method that is decorated, the decorators should probably also be public? perhaps debatable, it just looks funny to me to have an
@_options.xyz()decorator
5ed277c to
17cf6ec
Compare
2e45a0a to
d855635
Compare
This allows you to deploy a configuration to a directory:
cloe-launch -v deploy -P engine/tests/conanfile_with_server.py /usr/local
This deployment should work without any further setup required.
An uninstaller is created at ~/.cache/cloe/launcher/UUID/uinstall.sh
where UUID is unique and determined from the configuration.
Readability and consistency are more important than performance here.
BREAKING CHANGE: This fundamentally changes how cloe-launch
parses arguments. They now have the form:
cloe-launch [OPTS] COMMAND [CMD_OPTS] CONANFILE [CONAN_INSTALL_ARGS] [-- ARGS]
For commands such as `shell` and `exec` it's now necessary to use `--`
to pass arguments to them. It is also no longer possible to provide
options to the cloe-launch command after specifying the conanfile.
These now go to conan.
And make commands.options a protected module.
This should result in more reliable builds by default.
This option lets you prevent Python configuration files from being loaded from CLOE_PLUGIN_PATH.
An empty entry in LD_LIBRARY_PATH is interpreted as the current working directory. Conan sets LD_LIBRARY_PATH in such a way that it inserts an empty entry, inadvertently.
Resolves eclipse/cloe #217.
This is important to let the user know that something is happening, if for example conan is doing something that takes a long time. This commit resolves eclipse/cloe issue #219.
And update Configuration type to use Path types instead of os.path.
mats4
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #193.
BREAKING CHANGE:
New:
deploydeploys everything to a single folder for redistribution.Improvements:
Development: