CI python: Disable Findlibs package #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI actions for python packages that depend on a compiled lib tend to fail now, due to the enablement of wheel-based delivery, which however ignores the just-compiled lib. In other words, when we ci-test pyodc, its not using the just-compiled odc, but some older version of it thats on pypi The proper fix would be about building wheels as well in the ci actions, and using them. But thats more complicated -- so we just globally disable this findlibs part. That leads to the (old) wheel still being installed, but at runtime findlibs would ignore it and pick the just-compiled one. This has already been done explicitly in the pymultio case -- but it makes more sense to control it globally
|
|
|
@iainrussell @figi44 could one of you guys pls review this one? I'm trying to achieve the same effect as https://github.com/ecmwf/downstream-ci/blob/main/.github/workflows/downstream-ci.yml#L2054 but for every python package tested under downstream-ci action -- is this PR going to do that? The PR is addressing failures like this https://github.com/ecmwf/pyodc/actions/runs/15019598744/job/42205429180?pr=39 |
|
I am OK with this, we should probably also do this in ecmwf/build-package-hpc |
|
This looks good to me - I'm happy to merge and tag |
|
Merged and tagged as 'v2' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI actions for python packages that depend on a compiled lib tend to fail now, due to the enablement of wheel-based delivery, which however ignores the just-compiled lib. In other words, when we ci-test pyodc, its not using the just-compiled odc, but some older version of it thats on pypi
The proper fix would be about building wheels as well in the ci actions, and using them. But thats more complicated -- so we just globally disable this findlibs part. That leads to the (old) wheel still being installed, but at runtime findlibs would ignore it and pick the just-compiled one.
This has already been done explicitly in the pymultio case -- but it makes more sense to control it globally