8000 cli: support http proxy by thomasten · Pull Request #3772 · edgelesssys/constellation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

cli: support http proxy #3772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

cli: support http proxy #3772

merged 1 commit into from
Apr 16, 2025

Conversation

thomasten
Copy link
Member

Context

This adds support for using the CLI behind an http proxy.
This is "best effort" for now and won't be documented.

Proposed change(s)

  • use default grpc dialer

Additional info

  • Tested manually. Won't add an e2e test for now.

@netlify Netlify
Copy link
netlify bot commented Apr 16, 2025

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 12d0112
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/67ff74ea43e8090008e0c9b1

@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Package Old New Trend
cli/internal/cmd 57.80% 57.80% ↔️
internal/grpc/dialer 100.00% 92.30% ↘️
terraform-provider-constellation/internal/provider 5.90% 5.90% 🚧

elchead
elchead approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor
@elchead elchead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

owned files lgtm

@thomasten thomasten merged commit d6567ec into main Apr 16, 2025
9 checks passed
@thomasten thomasten deleted the t/proxy branch April 16, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elchead elchead elchead approved these changes

@msanft msanft msanft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasten @elchead @msanft
0