8000 docs: correct english description at README by atian25 · Pull Request #400 · eggjs/egg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: correct english description at README #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2017
Merged

docs: correct english description at README #400

merged 1 commit into from
Feb 17, 2017

Conversation

atian25
Copy link
Member
@atian25 atian25 commented Feb 17, 2017
Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@atian25 atian25 requested a review from popomore February 17, 2017 03:49
@mention-bot
Copy link

@atian25, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2, @dead-horse and @popomore to be potential reviewers.

@codecov
Copy link
codecov bot commented Feb 17, 2017 •
edited
Loading

Codecov Report

Merging #400 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #400   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          28     28           
  Lines         644    644           
=====================================
  Hits          644    644

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05f2586...390ef41. Read the comment docs.

shaoshuai0102
shaoshuai0102 requested changes Feb 17, 2017
View reviewed changes
README.md Outdated
@@ -43,7 +43,11 @@ Node.js >= 6.0.0 required.
- [Plugins](https://github.com/search?q=topic%3Aegg-plugin&type=Repositories)
- [Frameworks](https://github.com/search?q=topic%3Aegg-framework&type=Repositories)

> English docs is still working in process, see [#360](https://github.com/eggjs/egg/issues/360).
> All the source, comment and README is english.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the sources, comments and the README is in English

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resources?

README.md Outdated
> English docs is still working in process, see [#360](https://github.com/eggjs/egg/issues/360).
> All the source, comment and README is english.
>
> Only guide docs is still working in process, see [#363](https://github.com/eggjs/egg/issues/363).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are still working...

Copy link
Member
@popomore popomore Feb 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The English document is still working in process

README.md Outdated
>
> Only guide docs is still working in process, see [#363](https://github.com/eggjs/egg/issues/363).
>
> Welcome to join us to translate egg document, we are glad to see that.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documents

@popomore
Copy link
Member

in one line?

@atian25
Copy link
Member Author
atian25 commented Feb 17, 2017

updated

popomore
popomore reviewed Feb 17, 2017
View reviewed changes
README.md Outdated
@@ -43,7 +43,8 @@ Node.js >= 6.0.0 required.
- [Plugins](https://github.com/search?q=topic%3Aegg-plugin&type=Repositories)
- [Frameworks](https://github.com/search?q=topic%3Aegg-framework&type=Repositories)

> English docs is still working in process, see [#360](https://github.com/eggjs/egg/issues/360).
> All the sources, comments and the README is in English, only the English guide documents are still [working in process](https://github.com/eggjs/egg/issues/363).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sources 这里是指源文件？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯, 干掉逗号?

Copy link
Member
@popomore popomore Feb 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source code? 而且代码是不可数的吧

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该想表达代码注释都是英文的, 源码肯定是英文的, 哈哈

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the jsdoc, comments and the README 怎么样?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the resources are in English(comments, README, etc.), with one exception, guides are still working in process.

别提 source code 了，难道代码还有不是英文的。。哈哈

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

信不信我今晚提交个易语言上来

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改了

@shaoshuai0102 shaoshuai0102 merged commit 58daaed into master Feb 17, 2017
@shaoshuai0102 shaoshuai0102 deleted the docs-english branch February 17, 2017 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popomore popomore popomore approved these changes

@shaoshuai0102 shaoshuai0102 shaoshuai0102 approved these changes

Assignees
No one assigned
Labels
type: document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atian25 @mention-bot @popomore @shaoshuai0102
0