refactor: plugin/schedule #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
PR Overview
This PR refactors the schedule plugin by migrating configuration to TypeScript and updating import paths and lifecycle hooks to use the new @eggjs/core API.
- Replaces the JavaScript configuration file with a TypeScript version.
- Updates imports to use @eggjs/core and appends necessary .js extensions.
- Modifies lifecycle hooks (e.g., beforeClose and didLoad) to be asynchronous.
Reviewed Changes
| File | Description |
|---|---|
| plugin/schedule/test/fixtures/schedule-app/config/plugin.ts | Adds a TS configuration file for the schedule plugin. |
| plugin/schedule/test/schedule.test.ts | Updates test imports and types; uses assert.match and adjusts app initialization. |
| plugin/schedule/index.ts | Introduces the plugin index file with the new tegg-plugin import. |
| plugin/schedule/app.ts | Refactors app boot hook to use @eggjs/core and adopts async lifecycle methods. |
| plugin/schedule/lib/ScheduleSubscriberRegister.ts | Updates import paths and log formatting for subscriber registration. |
| plugin/schedule/lib/ScheduleWorkerRegister.ts | Adjusts import paths for scheduling worker registration. |
| plugin/schedule/lib/EggScheduleAdapter.ts | Updates import from egg to @eggjs/core. |
| plugin/schedule/lib/ScheduleWorkerLoadUnitHook.ts | Updates import paths to include file extension. |
| plugin/schedule/agent.ts | Refactors agent boot hook to use ILifecycleBoot and updates async lifecycle hooks. |
| plugin/schedule/test/fixtures/schedule-app/config/plugin.js | Removes the deprecated JavaScript configuration file. |
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #290 +/- ##
==========================================
+ Coverage 80.57% 81.74% +1.16%
==========================================
Files 398 399 +1
Lines 12794 12824 +30
Branches 2146 2182 +36
==========================================
+ Hits 10309 10483 +174
+ Misses 2485 2341 -144 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.