fix: export Orm class #293
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
PR Overview
This pull request fixes the export for the Orm class and related components while also adding a new charset property in the Orm configuration. It also updates the import style of a dependency in the standalone test to reflect the module's export changes.
- Add a new test to ensure Orm is exported correctly.
- Modify OrmConfig to include a charset property along with a flexible index signature.
- Update the exports and import syntax in index.ts and the standalone test file.
Reviewed Changes
| File | Description |
|---|---|
| plugin/orm/test/exports.test.ts | Added a snapshot test for exported members |
| plugin/orm/lib/DataSourceManager.ts | Extended OrmConfig with a charset and additional properties |
| plugin/orm/index.ts | Updated exports to include LeoricRegister alongside Orm |
| plugin/orm/lib/LeoricRegister.ts | No functional changes; reference for export |
| standalone/standalone/test/index.test.ts | Adjusted import style for the mm module |
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
plugin/orm/index.ts:9
- LeoricRegister is exported without being imported in this file. Please add an import statement (e.g., import { LeoricRegister } from './lib/LeoricRegister.js';) to ensure it is properly referenced.
export { Orm, LeoricRegister };
standalone/standalone/test/index.test.ts:6
- Verify that the 'mm' module supports a named import. If the module only exports a default export, consider reverting to the original syntax.
import { mm } from 'mm';
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #293 +/- ##
==========================================
+ Coverage 88.39% 88.42% +0.03%
==========================================
Files 401 401
Lines 13042 13072 +30
Branches 2221 2260 +39
==========================================
+ Hits 11528 11559 +31
+ Misses 1514 1513 -1 ☔ View full report in Codecov by Sentry. |
No description provided.