8000 fix: dep by akitaSummer · Pull Request #313 · eggjs/tegg · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: dep #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

fix: dep #313

merged 1 commit into from
May 7, 2025

Conversation

akitaSummer
Copy link
Contributor
@akitaSummer akitaSummer commented May 7, 2025 •
edited by coderabbitai bot
Loading
Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Summary by CodeRabbit

  • New Features

    • Introduced a new standardized protocol enumeration for use across the application.

  • Chores

    • Updated internal module imports for protocol types to improve consistency.
    • Added new files to the package distribution and included a new runtime dependency.

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 7, 2025 •
edited
Loading

Walkthrough

The changes refactor the definition and import of the MCPProtocols enum. The enum is moved from plugin/mcp-proxy/index.ts to a new plugin/mcp-proxy/types.ts file, and all references are updated accordingly. The package configuration and type declarations are also modified to reflect this change, with no logic or control flow affected.

Changes

File(s) Change Summary
plugin/controller/lib/impl/mcp/MCPControllerRegister.ts Updated import path for MCPProtocols to use '@eggjs/mcp-proxy/types'.
plugin/mcp-proxy/index.ts Removed local MCPProtocols enum; now imports it from ./types.
plugin/mcp-proxy/types.ts Introduced new exported enum MCPProtocols with members STDIO, SSE, STREAM.
plugin/mcp-proxy/typings/index.d.ts Changed export source of MCPProtocols from '../index' to '../types'.
plugin/mcp-proxy/test/fixtures/apps/mcp-proxy/app/controller/app.ts Updated import path for MCPProtocols to use the new types location.
plugin/mcp-proxy/package.json Added types.js and types.d.ts to files; added eventsource-parser dependency.

Suggested reviewers

  • killagu

Poem

In the warren where enums dwell,
A protocol hopped to types as well.
From index it leapt, with a joyful cheer,
Now all the imports are crystal clear!
With tidy paths and types anew,
This bunny codes for me and you.
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

plugin/controller/lib/impl/mcp/MCPControllerRegister.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-eggache".

(The package "eslint-plugin-eggache" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-eggache@latest --save-dev

The plugin "eslint-plugin-eggache" was referenced from the config file in ".eslintrc » eslint-config-egg/typescript » ./index.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

plugin/mcp-proxy/types.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-eggache".

(The package "eslint-plugin-eggache" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-eggache@latest --save-dev

The plugin "eslint-plugin-eggache" was referenced from the config file in ".eslintrc » eslint-config-egg/typescript » ./index.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

plugin/mcp-proxy/index.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-eggache".

(The package "eslint-plugin-eggache" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-eggache@latest --save-dev

The plugin "eslint-plugin-eggache" was referenced from the config file in ".eslintrc » eslint-config-egg/typescript » ./index.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

  • 2 others
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@akitaSummer akitaSummer force-pushed the fix/mcp_teggCtxLifecycleMiddleware branch from d19fc07 to 5b599ef Compare May 7, 2025 06:22
coderabbitai[bot]
coderabbitai bot reviewed May 7, 2025
View reviewed changes
Copy link
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
plugin/mcp-proxy/test/fixtures/apps/mcp-proxy/app/controller/app.ts (1)

12-12: Prefer using the published package import for MCPProtocols.
The deep relative path is brittle and does not reflect real-world consumption of the plugin. Importing directly from the package API makes fixtures clearer and more robust:

- import { MCPProtocols } from '../../../../../../types';
+ import { MCPProtocols } from '@eggjs/mcp-proxy/types';
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5304384 and 5b599ef.

📒 Files selected for processing (6)
  • plugin/controller/lib/impl/mcp/MCPControllerRegister.ts (1 hunks)
  • plugin/mcp-proxy/index.ts (1 hunks)
  • plugin/mcp-proxy/package.json (2 hunks)
  • plugin/mcp-proxy/test/fixtures/apps/mcp-proxy/app/controller/app.ts (1 hunks)
  • plugin/mcp-proxy/types.ts (1 hunks)
  • plugin/mcp-proxy/typings/index.d.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Runner-ubuntu (22)
  • GitHub Check: Runner-ubuntu (18)
  • GitHub Check: Runner-ubuntu (20)
  • GitHub Check: Runner-ubuntu (16)
  • GitHub Check: Runner-macos (18)
  • GitHub Check: Runner-macos (16)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (typescript)
🔇 Additional comments (6)
plugin/mcp-proxy/package.json (2)

23-24: Correctly include new type definition files in the published package.
Adding types.js and types.d.ts to the files array ensures that the relocated MCPProtocols enum is bundled on npm.

59-59: Verify eventsource-parser subpath import compatibility.
Ensure that version ^3.0.1 exposes a stream entry point (eventsource-parser/stream) as used in the codebase.

plugin/mcp-proxy/typings/index.d.ts (1)

5-5: Re-export MCPProtocols from the new types module.
Updating the export source to '../types' aligns with the refactoring and ensures downstream TypeScript consumers see the correct enum.

plugin/mcp-proxy/index.ts (1)

16-16: Import MCPProtocols from the dedicated types file.
Switching to ./types keeps the runtime import in sync with where the enum is defined.

plugin/controller/lib/impl/mcp/MCPControllerRegister.ts (1)

23-23: Update import path for MCPProtocols.
Importing from @eggjs/mcp-proxy/types reflects the relocation of the enum and maintains type consistency.

plugin/mcp-proxy/types.ts (1)

1-5: Well-formed enum definition.
The MCPProtocols enum cleanly centralizes the protocol constants with matching string values. Naming is consistent, and the file structure aligns with the refactor.

killagu
killagu approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor
@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akitaSummer akitaSummer merged commit 791feea into eggjs:master May 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@killagu killagu killagu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akitaSummer @killagu
0