1776 implementation of the bic attenuated hits #1783
+372
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"EcalBarrelScFiPAttenuatedHits" (readout at p-going side) and "EcalBarrelScFiNAttenuatedHits" (readout at e-going side) were added.
Constants and plugins for "EcalBarrelScFiPAttenuatedHits" and "EcalBarrelScFiNAttenuatedHits" were added.
1. Regroup the "SimCalorimeterHit"s by primary "MCParticle". 2. Add up the "SimCalorimeterHit"s if they have the same z-segmentation. 3. Attenuate the energy of the "SimCalorimeterHit"s.
Open
for more information, see https://pre-commit.ci
|
Can you remove the duplicate files at the project top level please? |
Capybara summary for PR 1783
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…mistakes in the code have been fixed
for more information, see https://pre-commit.ci
… corrected so that they follow the same unit system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR adds new factory, output, plugin, algorithm for
SimCalorimeterHitby primary MC particle.SimCalorimeterHitwith respect to a common quantity, e.g., same z-segmentation.SimCalorimeterHit.SimCalorimeterHitand correspondingCaloHitContributionin the output.For detectors that don't need 2. or 3.,
is_mergeandis_attenuationcan be used to include or omit them. Because the algorithm has multiple functions forSimCalorimeterHit, we named itSimCalorimeterHitProcessor.The Barrel Imaging Calorimeter (BIC) will use all the above three functions. Therefore, the followings have been added or updated accordingly.
src/factories/calorimetry/SimCalorimeterHitProcessor_factory.hsrc/services/io/podio/JEventProcessorPODIO.ccEcalBarrelScFiPAttenuatedHits(for readout at p-going side),EcalBarrelScFiNAttenuatedHits(for readout at e-going side),EcalBarrelScFiPAttenuatedHitContributions, andEcalBarrelScFiNAttenuatedHitContributionswere added.src/detectors/BEMC/BEMC.ccConstants and plugins for
EcalBarrelScFiPAttenuatedHits,EcalBarrelScFiNAttenuatedHits,EcalBarrelScFiPAttenuatedHitContributions, andEcalBarrelScFiNAttenuatedHitContributionswere added.src/algorithms/calorimetry/SimCalorimeterHitProcessorConfig.hsrc/algorithms/calorimetry/SimCalorimeterHitProcessor.hsrc/algorithms/calorimetry/SimCalorimeterHitProcessor.ccTwo types of the energy distributions below were compared to cross-check the new algorithm and they showed the same distributions.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
No