8000 fix: move implementation out of headers for compilation speed by wdconinc · Pull Request #1853 · eic/EICrecon · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: move implementation out of headers for compilation speed #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix: move implementation out of headers for compilation speed #1853

wants to merge 11 commits into from

Conversation

wdconinc
Copy link
Contributor
@wdconinc wdconinc commented May 7, 2025 •
edited
Loading

Briefly, what does this PR introduce?

This PR takes the largest headers, and moves implementations into a dedicate cc file. This may speed up compilation, though the only header that is included in a significant number of other cc files is the CalorimeterIslandCluster.h.

No code changes beyond moving implementation to cc.

Needs:

What kind of change does this PR introduce?

  • Bug fix (issue: definition and implementation should be separate)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@github-actions github-actions bot added the topic: calorimetry relates to calorimetry label May 7, 2025
@wdconinc wdconinc requested review from a team and veprbl and removed request for a team May 7, 2025 00:51
@wdconinc wdconinc force-pushed the algorithms-implementation-in-cc branch 2 times, most recently from f82cd17 to dda2d79 Compare May 9, 2025 03:17
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 10, 2025 •
edited
Loading

Capybara summary for PR 1853

@wdconinc wdconinc enabled auto-merge May 10, 2025 15:40
@wdconinc wdconinc force-pushed the algorithms-implementation-in-cc branch from 17637aa to 8ea81eb Compare May 23, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl Awaiting requested review from veprbl veprbl was automatically assigned from eic/epic-eicrecon-review

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
topic: calorimetry relates to calorimetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wdconinc
0