8000 run_material_map_validation.sh: update Acts to v36.3.2 by veprbl · Pull Request #868 · eic/epic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

run_material_map_validation.sh: update Acts to v36.3.2 #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025
Merged

Conversation

veprbl
Copy link
Member
@veprbl veprbl commented May 26, 2025

Briefly, what does this PR introduce?

We've updated Acts in container, this need to be updated too.

Closes: #863

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

Yes

@github-actions github-actions bot added the topic: infrastructure Regarding build system, CI, CD label May 26, 2025
@veprbl
Copy link
Member Author
veprbl commented May 26, 2025

This seems to work.

Current material map looks slightly off on both master (had to be still old Acts v35):
image
and with this
image
could it be the BTOF update #848?

_v44_b0_l2_a1_s0_X0.pdf
image
_v44_b0_l2_a2_s0_X0.pdf
image
cc @ShujieL

@veprbl veprbl enabled auto-merge (squash) May 26, 2025 21:02
@veprbl veprbl requested a review from wdconinc May 26, 2025 21:02
@veprbl veprbl mentioned this pull request May 26, 2025
@veprbl veprbl merged commit 4fb92ec into main May 27, 2025
139 checks passed
@veprbl veprbl deleted the pr/acts_36_3_2 branch May 27, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Regarding build system, CI, CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom eta range in material map validation, requires ACTS 36.1
2 participants
0