chore(rpc,node)!: Fix clippy issues #626
Merged
+20
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors error handling to address Clippy suggestions and adjust the gRPC error type.
- Replaces
io::Error::newcalls with theio::Error::otherconstructor in the P2P header codec. - Changes the
Error::TonicErrorvariant to store a boxedStatusand adds a manualFrom<Status>implementation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| node/src/p2p/header_ex.rs | Swapped io::Error::new(...) for io::Error::other(...). |
| grpc/src/error.rs | Converted TonicError to Box<Status> and added From. |
Comments suppressed due to low confidence (2)
grpc/src/error.rs:17
- Boxing
Statusintroduces a heap allocation for every gRPC error. Consider using#[from] Statusdirectly to avoid the extra allocation unless boxing is strictly required.
TonicError(Box<Status>),
grpc/src/error.rs:72
- [nitpick] Because the
#[from]macro was removed from the variant, this manual impl is needed. It may be clearer to add a comment explaining why boxing is required or revert to the derive-based#[from] Statuspattern.
impl From<Status> for Error {
zvolin
approved these changes
May 20, 2025
fl0rek
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.