8000 feat(rpc)!: update jsonrpsee to version 0.25.1 and refactor RPC methods by YakupAltay · Pull Request #620 · eigerco/lumina · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(rpc)!: update jsonrpsee to version 0.25.1 and refactor RPC methods #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 29, 2025
Merged

feat(rpc)!: update jsonrpsee to version 0.25.1 and refactor RPC methods #620

merged 8 commits into from
Apr 29, 2025

Conversation

YakupAltay
Copy link
Contributor
@YakupAltay YakupAltay commented Apr 26, 2025 •
edited
Loading

Fixes #575

@YakupAltay
Copy link
Contributor Author

Hey @oblique!

I think there is a problem with the CI. I did not have these errors when I tested locally thanks to your recommendation (#575).

I would love to make the necessary changes if you could guide me.

@oblique
Copy link
Member
oblique commented Apr 28, 2025

@YakupAltay The errors from the test cases are a bit weird and my first thought was that a dependency broke deserialization. I saw that you updated all the dependencies instead of just the ones that are related to jsonrpsee. After I reverted your fix: Update Cargo.lock the tests are passing.

For now revert that commit, run the test and commit only what cargo changed in Cargo.lock. Do not update anything else until we find out which dependency breaks our deserialization.

@oblique
Copy link
Member
oblique commented Apr 28, 2025

@YakupAltay I manage to find the culprit. After I update tendermint 0.4.0 to 0.4.3 the tests start to fail. I will investigate it further, but for this PR don't update it.

@YakupAltay
Copy link
Contributor Author

Hey @oblique, I reverted it and updated only jsonrpsee related packages via this command:
cargo update -p jsonrpsee

Yet, the tests are still failing.

@oblique
Copy link
Member
oblique commented Apr 29, 2025

Now CI fails for different reasons:

  • Because of clippy lints
  • You forgot to remove #[async_trait] for the wasm code in rpc/src/client.rs

Run these:

cargo clippy
cargo clippy --target=wasm32-unknown-unknown

@YakupAltay
Copy link
Contributor Author

Silly me!

Fixed them all, @oblique.

@oblique oblique changed the title feat(rpc): update jsonrpsee to version 0.25.1 and refactor RPC methods feat(rpc)!: update jsonrpsee to version 0.25.1 and refactor RPC methods Apr 29, 2025
oblique
oblique approved these changes Apr 29, 2025
View reviewed changes
Copy link
Member
@oblique oblique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @YakupAltay

@oblique oblique merged commit 1a481a5 into eigerco:main Apr 29, 2025
32 checks passed
@zvolin zvolin mentioned this pull request Apr 29, 2025
Closed
@oblique oblique mentioned this pull request Apr 30, 2025
Closed
@zvolin zvolin mentioned this pull request Apr 30, 2025
Closed
This was referenced May 14, 2025
Closed
Closed
@zvolin zvolin mentioned this pull request May 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oblique oblique oblique approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use jsonrpsee namespaces instead of manually prefixing all the methods
2 participants
@YakupAltay @oblique
0