8000 [Feature] increase menu load speed when no emoji change beetween two pages by mrsolarius · Pull Request #3 · eilex/discord.js-embed-menu · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Feature] increase menu load speed when no emoji change beetween two pages #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[Feature] increase menu load speed when no emoji change beetween two pages #3

wants to merge 10 commits into from

Conversation

mrsolarius
Copy link
Contributor
@mrsolarius mrsolarius commented Aug 1, 2021 8000

This PR increases the speed of loading embed menu when no reaction change between two. It's possible because when no reaction change they are no need to call addReactions() and this method take 0,2 to 0,7 second to be executed multiply by number of emoji.
So, I have to convert reactionsChanged var to a class attribute and I use it to not call addReactions() on setPage() method

I also update dependency version to be able to correctly generate the documentation.

Finally, I have regenerated docs and code distribution

@mrsolarius mrsolarius changed the title [Feature] increase menu load speed when no emoji change beetween to pages [Feature] increase menu load speed when no emoji change beetween two pages Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mrsolarius
0