8000 chore: bump to Go 1.22 by Jassob · Pull Request #336 · einride/can-go · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: bump to Go 1.22 #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

chore: bump to Go 1.22 #336

merged 1 commit into from
May 13, 2025

Conversation

Jassob
Copy link
Member
@Jassob Jassob commented May 12, 2025

Go 1.22 is the oldest officially supported version of Go currently and
at Einride we aim to follow that guideline.

In order to get the project to build a number of other changes needed
to be done.

go.einride.tech/sage needed to be updated to get us a golangci-lint
version that can lint 1.22 and with that a whole swath of lints were
activated:

  • most are on the form of copyloopvar (i.e. loop variables
    now work as most people expect and we don't need to copy them)
  • we were also shadowing min/max builtins that were introduced in Go
    1.21, these are now renamed were applicable.

BREAKING CHANGE: The library requires Go 1.22 to build, no other user
visible changes introduced.

@Jassob Jassob self-assigned this May 12, 2025
@Jassob Jassob marked this pull request as ready for review May 13, 2025 07:34
Go 1.22 is the oldest officially supported version of Go currently and
at Einride we aim to follow that guideline.

In order to get the project to build a number of other changes needed
to be done.

go.einride.tech/sage needed to be updated to get us a golangci-lint
version that can lint 1.22 and with that a whole swath of lints were
activated:
- most are on the form of copyloopvar (i.e. loop variables
  now work as most people expect and we don't need to copy them)
- we were also shadowing min/max builtins that were introduced in Go
  1.21, these are now renamed were applicable.

BREAKING CHANGE: The library requires Go 1.22 to build, no other user
visible changes introduced.
@Jassob Jassob force-pushed the chore/bump-go-1.22 branch from 95bf1bf to a0250e4 Compare May 13, 2025 07:52
Copy link
Member
@ericwenn ericwenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jassob Jassob merged commit ab1c5ca into master May 13, 2025
1 check passed
@Jassob Jassob deleted the chore/bump-go-1.22 branch May 13, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0