Improve quoting of varibles in the node shim for -n system #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch, @asottile ! But we have a problem for python 2.7: From here: https://travis-ci.org/github/ekalinin/nodeenv/jobs/693637385 Yeah, i know that python 2.7 is EOL, but i believe a lot of people still use it. |
|
What about: ? |
|
oh! yeah I'll just pipes.quotes -- forgot about ye olde python 2 :) |
- this isn't quite perfect, for example a node environment containaing a single quote character will still produce problems. but this is an improvement - a more thorough approach would be to use `shlex.quote` -- however I'm not 100% certain how that would interact with other shells and particularly windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
single quote character will still produce problems. but this is an
improvement
shlex.quote-- however I'm not100% certain how that would interact with other shells and particularly
windows
Resolves pre-commit/pre-commit#1483