10000 [REFACTORING]: Enhance existing TypeScript types and improve clarity by ShueiYang · Pull Request #26 · ekino/v6y · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[REFACTORING]: Enhance existing TypeScript types and improve clarity #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

[REFACTORING]: Enhance existing TypeScript types and improve clarity #26

merged 1 commit into from
Nov 5, 2024

Conversation

ShueiYang
Copy link
Contributor
@ShueiYang ShueiYang commented Nov 1, 2024 •
edited
Loading

[REFACTORING]: Enhance existing TypeScript types and improve clarity

Description

  • It's just a first small PR to suggest some TypeScript type improvement, ofc, the review is still in progress and this is the first suggestion ^^

Note:

  • The type change in the reduce method for example aims to reduce boilerplate by allowing TypeScript to infer types automatically, rather than specifying them explicitly.
  • I use Record<string, string[]> because I think this syntaxe is much better for readability, this assertion can also be { [key: string]: string[] }

helabenkhalfallah
helabenkhalfallah approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor
@helabenkhalfallah helabenkhalfallah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much :)

@helabenkhalfallah helabenkhalfallah merged commit 3805574 into ekino:main Nov 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helabenkhalfallah helabenkhalfallah helabenkhalfallah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShueiYang @helabenkhalfallah
0