Tags: ekusiadadus/bitcoin-abc
Tags
[Chronik] Add line to CONTRIBUTING.md and install-dependencies.sh ens… …uring rustfmt when installing nightly Summary: On some machines, the current set of commands won't necessarily install the rustfmt component. Adding this call to both CONTRIBUTING.md and install-dependencies.sh doesn't error when rustfmt is already there, but will install it if it isn't. Test Plan: Run the commands in e.g. a clean docker environment, will either install rustfmt or output `info: component 'rustfmt' for target '<target>' is up to date` Reviewers: Fabien, #bitcoin_abc Reviewed By: Fabien, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D11718
[Cashtab] Hide Add To Contacts option if sender is a contact Summary: Related to T2412. Added conditional logic to hide the Add To Contact option in TxHistory if the sender is already a contact. Test Plan: cd web/cashtab && npm start From TxHistory: Click on a received Tx from a wallet that is not a contact and add the contact Refresh the page and navigate back to TxHistory Observe that the Add to Contacts option no longer appears for Txs received from the contact Reviewers: bytesofman, #bitcoin_abc Reviewed By: bytesofman, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D11525
[Cashtab] Center collapse headers in Send.js Summary: First step in task T2348. The headers of the three styled collapses in Send.js should be centered, with the arrow icon staying to the left of the collapse. Test Plan: cd web/cashtab && npm start navigate to the Send page observe that in each of the 3 styled collapses, the header is centered Reviewers: bytesofman, #bitcoin_abc Reviewed By: bytesofman, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D11315
Use the actual config in the RPC console Summary: The Qt RPC console uses a default config and causes the RPC to behave slightly differently than they do from bitcoind. This diff fixes that by forwarding the config at execution time. Test Plan: ninja all check-all On the RPC console, run getnewaddress and check it returns an ecash address (was a legacy one before the patch). Reviewers: #bitcoin_abc, tyler-smith Reviewed By: #bitcoin_abc, tyler-smith Subscribers: Mengerian Differential Revision: https://reviews.bitcoinabc.org/D11370
[avalanche] Erase the avalanche nodes that get disconnected 81AA Summary: Right now only the nodes that failed to get queried after an attempt are removed from the avalanche datastructure. That means that there is no mechanims for removing nodes that never get selected for polling or are pending a proof should they get disconnected. This diff addresses this issue by having the avalanche processor implementing the `NetEventsInterface` and allowing the `CConnman` to take several of these interfaces. By doing so the processor gets notified on each node disconnection via the `FinalizeNode` method and can handle the node removal properly. This design would benefit from being turned into a proper notification handler with a register/unregister interface, but this is out of scope for this diff. Depends on D11300 and D11301 (prevent reverse lock on shutdown). Test Plan: With Clang and Debug: ninja all check-all Run the ASAN and TSAN builds. Reviewers: #bitcoin_abc, tyler-smith Reviewed By: #bitcoin_abc, tyler-smith Subscribers: tyler-smith Differential Revision: https://reviews.bitcoinabc.org/D11302
Fix the build on some platforms by using an explicit cast for Univalu… …e type Summary: It appears that std::vector::size_type is not implicitely convertible to uint64_t or int64_t on on platforms , so cast it explicitely. Test Plan: ./contrib/teamcity/build-configurations.py build-linux32 ./contrib/teamcity/build-configurations.py build-native-osx Reviewers: #bitcoin_abc, tyler-smith Reviewed By: #bitcoin_abc, tyler-smith Subscribers: tyler-smith Differential Revision: https://reviews.bitcoinabc.org/D11244
Run the activated tests using the next upgrade Summary: Replace axions with gluons. This causes the CI to check that the tests remain green after next upgrade. Depends on D11075. Test Plan: ninja check-upgrade-activated-extended Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Differential Revision: https://reviews.bitcoinabc.org/D11080
PreviousNext