Update to Rust 1.85 and Rust 2024 Edition #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2021 edition, `impl Trait` in return position was assumed not to use any type params or lifetimes, but now in 2024 edition it is permitted to use by any lifetimes or type params in the function signature. Maybe that makes sense as a default, but there was one place where the old behavior was assumed, and broke under the new behavior. See https://blog.rust-lang.org/2024/09/05/impl-trait-capture-rules.html#impl-traits-can-include-a-use-bound-to-specify-precisely-which-generic-types-and-lifetimes-they-use
I didn't want to do this as part of the Rust 2024 edition migration, but it's so out of date now that it's breaking the build. I could expend some energy to modify the build to use a deliberately ancient version of the tool, or I can use that to migrate to the new version. Hopefully I made the right decision.
This is another yak shave that isn't directly related to the update to Rust 2024 edition but it getting in the way of landing it. The GHA build used an ancient version of cargo-udeps that worked on an ancient version of nightly. The rest of the company's projects have long since moved on from this. So I'm switching to cargo-machete, which found some unused deps that I also removed.
oandrukh
approved these changes
Mar 2, 2025
Veetaha
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a pretty easy transition,
cargo fixandcargo fmtdid almost everything. I updated torand0.9 which deprecates thegen*methods now thatgenis a reserved keyword, and there was one place where I had to add ause<>impl trait bound.