8000 [8.x](backport #42066) refactor: drop custom fsync implementation by mergify[bot] · Pull Request #43050 · elastic/beats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[8.x](backport #42066) refactor: drop custom fsync implementation #43050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2025
Merged

[8.x](backport #42066) refactor: drop custom fsync implementation #43050

merged 2 commits into from
Mar 11, 2025

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Mar 5, 2025

Proposed commit message

upstream is using F_FULLFSYNC on darwin
call stdlib f.sync and remove custom fsync implementation

See https://go.dev/doc/go1.12#ospkgos

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

This is an automatic backport of pull request #42066 done by [Mergify](https://mergify.com).

@kruskall @mergify
refactor: drop custom fsync implementation (#42066)
73f9672 
* refactor: drop custom fsync implement

upstream is using F_FULLFSYNC on darwin
call stdlib f.sync and remove custom fsync implementation

* lint: fix linting errors

* Update util.go

(cherry picked from commit 40a68d4)
@mergify mergify bot requested a review from a team as a code owner March 5, 2025 16:13
@mergify mergify bot added the backport label Mar 5, 2025
@mergify mergify bot requested review from AndersonQ and leehinman and removed request for a team March 5, 2025 16:13
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 5, 2025
@github-actions github-actions bot added enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Mar 5, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 5, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

leehinman
leehinman approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor
@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport looks correct

@mergify Mergify
Copy link
Contributor Author
mergify bot commented Mar 10, 2025

This pull request has not been merged yet. Could you please review and merge it @kruskall? 🙏

@AndersonQ AndersonQ removed their request for review March 10, 2025 16:31
@pierrehilbert
Copy link
Collaborator

@kruskall this one looks good to go

@kruskall kruskall merged commit 2c68621 into 8.x Mar 11, 2025
143 checks passed
@kruskall kruskall deleted the mergify/bp/8.x/pr-42066 branch March 11, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

@kruskall kruskall kruskall approved these changes

Assignees

@kruskall kruskall

Labels
backport enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elasticmachine @pierrehilbert @leehinman @kruskall
0