10000 [8.x](backport #41506) Remove functionbeat by dliappis · Pull Request #43090 · elastic/beats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[8.x](backport #41506) Remove functionbeat #43090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 10, 2025

Conversation

dliappis
Copy link
Contributor
@dliappis dliappis commented Mar 6, 2025

Proposed commit message

This PR is a manual backport of #41506 removing functionbeat.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

Dependent PRs:

  • [ ]

Related issues

Relates #40745

@botelastic botelastic bot added the needs_team Indicates that t 8000 he issue/PR needs a Team:* label label Mar 6, 2025
This PR is a manual backport of elastic#41506 removing functionbeat.
Relates elastic#40745
@dliappis dliappis force-pushed the remove-functionbeat-from-8.x branch from 316f3bc to 598cb59 Compare March 6, 2025 17:00
@dliappis dliappis marked this pull request as ready for review March 7, 2025 10:00
@dliappis dliappis requested review from a team as code owners March 7, 2025 10:00
@dliappis dliappis requested review from AndersonQ and belimawr and removed request for a team March 7, 2025 10:00
Copy link
Collaborator
@jlind23 jlind23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT Lint is not happy.

@pierrehilbert
Copy link
Collaborator

We are removing functiobeat starting with 9.0 so we shouldn't backport this one.

@dliappis
Copy link
Contributor Author
dliappis commented Mar 7, 2025

NIT Lint is not happy.

Thanks! FYI the particular lint failure is unrelated to this PR and wasn't addressed in the previous one either https://github.com/elastic/beats/pull/41506/files#r1832662377

@dliappis
Copy link
Contributor Author

NOTE for reviewers:

This is ready to be reviewed. It must be merged, however, only after the package has been removed from the expected list on the release manager (elastic internal PR link)

AndersonQ
AndersonQ previously approved these changes Mar 10, 2025
@AndersonQ AndersonQ dismissed their stale review March 10, 2025 14:11

I'll check it further

@AndersonQ AndersonQ enabled auto-merge (squash) March 10, 2025 14:32
dliappis added a commit to dliappis/beats that referenced this pull request Mar 10, 2025
This commit is a forward port of the change introduced in 8.x
(and earlier) via elastic#43090 to help
reduce potential conflicts with future backports.
dliappis added a commit to dliappis/beats that referenced this pull request Mar 10, 2025
This commit is a forward port of the change introduced in 8.x
(and earlier) via elastic#43090 to help
reduce potential conflicts with future backports.
dliappis added a commit to dliappis/beats that referenced this pull request Mar 10, 2025
This commit is a forward port of the change introduced in 8.x
(and earlier) via elastic#43090 to help
reduce potential conflicts with future backports.
@AndersonQ AndersonQ added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Mar 10, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 10, 2025
@AndersonQ AndersonQ merged commit 042a541 into elastic:8.x Mar 10, 2025
142 of 145 checks passed
mergify bot pushed a commit that referenced this pull request Mar 10, 2025
* Remove functionbeat

This PR is a manual backport of #41506 removing functionbeat.
Relates #40745

* Update NOTICE.txt

* Pin python for check-dev-tools

---------

Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
(cherry picked from commit 042a541)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
mergify bot pushed a commit that referenced this pull request Mar 10, 2025
* Remove functionbeat

This PR is a manual backport of #41506 removing functionbeat.
Relates #40745

* Update NOTICE.txt

* Pin python for check-dev-tools

---------

Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
(cherry picked from commit 042a541)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
#	x-pack/functionbeat/Dockerfile
#	x-pack/functionbeat/main_test.go
#	x-pack/functionbeat/provider/aws/cmd/root.go
#	x-pack/functionbeat/provider/aws/main_test.go
#	x-pack/functionbeat/provider/local/main_test.go
mergify bot pushed a commit that referenced this pull request Mar 10, 2025
* Remove functionbeat

This PR is a manual backport of #41506 removing functionbeat.
Relates #40745

* Update NOTICE.txt

* Pin python for check-dev-tools

---------

Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
(cherry picked from commit 042a541)
dliappis added a commit that referenced this pull request Mar 11, 2025
…43154)

This PR is a manual backport of #41506 removing functionbeat.
Relates #40745

---------

Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
(cherry picked from commit 042a541)

* remove pin python for check-dev-tools

* Revert "remove pin python for check-dev-tools"

This reverts commit 1716121.

* fix changelog

* go mod tidy

---------

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
dliappis added a commit to dliappis/beats that referenced this pull request Mar 12, 2025
This commit removes x-pack/functionbeat from the DRA process, which
was missed from elastic#43090
dliappis added a commit that referenced this pull request Mar 12, 2025
This commit removes x-pack/functionbeat from the DRA process in the 8.x branch, which was missed from #43090
It fixes the currently broken 8.x DRA which is still attempting to build x-pack/functionbeat after the corresponding
scripts got removed via #43090
dliappis added a commit that referenced this pull request Mar 12, 2025
…43152)

This PR is a manual backport of #41506 removing functionbeat
on the 8.16 branch.

Relates #40745

---------

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
jlind23 pushed a commit that referenced this pull request Mar 12, 2025
…43153)

* [8.x](backport #41506) Remove functionbeat (#43090)

* Remove functionbeat

This PR is a manual backport of #41506 removing functionbeat.
Relates #40745

* Update NOTICE.txt

* Pin python for check-dev-tools

---------

Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
(cherry picked from commit 042a541)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum

* fix conflicts

* remove pin python for check-dev-tools

* Revert "remove pin python for check-dev-tools"

This reverts commit 2fbbd03.

* fix changelog

---------

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
dliappis added a commit that referenced this pull request Mar 12, 2025
This commit is a forward port of the change introduced in 8.x
(and earlier) via #43090 to help
reduce potential conflicts with future backports.
mergify bot pushed a commit that referenced this pull request Mar 12, 2025
This commit is a forward port of the change introduced in 8.x
(and earlier) via #43090 to help
reduce potential conflicts with future backports.

(cherry picked from commit 7e2445f)
dliappis added a commit that referenced this pull request Mar 12, 2025
This commit is a forward port of the change introduced in 8.x
(and earlier) via #43090 to help
reduce potential conflicts with future backports.

(cherry picked from commit 7e2445f)

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0