Cherry-pick #4303 to 5.4: Use .go-version to specify the Go version for all CI builds #4403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d377c4 to
0107243
Compare
…4303) Having a simple file that requires no parsing to retrieve the Go version provides us a standard portable way to know what Go version to use for builds. It's basically the least common denominator for builds accross CI systems (Jenkins, AppVeyor, Travis) and operating systems. Also changed AppVeyor to invalidate the cached Go version only when the .go-version file changes instead of when the .appveyor.yml changes. (cherry picked from commit 795ceab)
0107243 to
e85caad
Compare
|
I'm going to merge this one, because the jenkins failures look unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #4303 to 5.4 branch. Original message:
Having a simple file that requires no parsing to retrieve the Go version
provides us a standard portable way to know what Go version to use for builds.
It's basically the least common denominator for builds accross CI systems
(Jenkins, AppVeyor, Travis) and operating systems.
Also changed AppVeyor to invalidate the cached Go version only when the
.go-version file changes instead of when the .appveyor.yml changes.