8000 [metricbeat][kafka] fix panic when fetching consumergroup member assignments by stefans-elastic · Pull Request #44576 · elastic/beats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[metricbeat][kafka] fix panic when fetching consumergroup member assignments #44576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jun 17, 2025
Merged

[metricbeat][kafka] fix panic when fetching consumergroup member assignments #44576

merged 16 commits into from
Jun 17, 2025

Conversation

stefans-elastic
Copy link
Contributor

Proposed commit message

[metricbeat][kafka] fix panic when fetching consumergroup member assignments.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@stefans-elastic stefans-elastic self-assigned this May 30, 2025
@stefans-elastic stefans-elastic added bug Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team labels May 30, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify Mergify
Copy link
Contributor
mergify bot commented May 30, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @stefans-elastic? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@stefans-elastic stefans-elastic added backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch backport-8.19 Automated backport to the 8.19 branch labels May 30, 2025
@stefans-elastic stefans-elastic marked this pull request as ready for review June 2, 2025 07:21
@stefans-elastic stefans-elastic requested a review from a team as a code owner June 2, 2025 07:21
@stefans-elastic stefans-elastic requested a review from a team as a code owner June 2, 2025 08:03
mykola-elastic
mykola-elastic reviewed Jun 2, 2025
View reviewed changes
mykola-elastic
mykola-elastic reviewed Jun 2, 2025
View reviewed changes
mykola-elastic
mykola-elastic reviewed Jun 2, 2025
View reviewed changes
colleenmcginnis
colleenmcginnis reviewed Jun 2, 2025
View reviewed changes
ishleenk17
ishleenk17 reviewed Jun 6, 2025
View reviewed changes
ishleenk17
ishleenk17 reviewed Jun 10, 2025
View reviewed changes
@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 12, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b kafka-panic-fix upstream/kafka-panic-fix
git merge upstream/main
git push upstream kafka-panic-fix

This was referenced Jun 13, 2025
Merged
Merged
@ishleenk17
Copy link
Contributor

@stefans-elastic: Since the clarity is not there on changelog yet.
Let's keep the changelog in changelog.next.asciidoc only.
That is what is being done in some of the recent merges to beats.

ishleenk17
ishleenk17 approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor
@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stefans-elastic stefans-elastic merged commit 91de405 into elastic:main Jun 17, 2025
48 checks passed
mergify bot pushed a commit that referenced this pull request Jun 17, 2025
@stefans-elastic @mergify
[metricbeat][kafka] fix panic when fetching consumergroup member assi…
42d2b95 
…gnments (#44576)

* [metricbeat][kafka] fix panic when fetching consumergroup member assignments

* add changelog entry

* mage fmt

* fix linter

* update new changelog

* fix behaviour in case of sarama error in MemberDescription conversion

* fix linter

* move changelog entry to appropriate version section

* remove entries from  docs/release-notes/index.md

---------

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
(cherry picked from commit 91de405)

# Conflicts:
#	metricbeat/module/kafka/broker_test.go
mergify bot pushed a commit that referenced this pull request Jun 17, 2025
@stefans-elastic @mergify
[metricbeat][kafka] fix panic when fetching consumergroup member assi…
dcbcfc2 
…gnments (#44576)

* [metricbeat][kafka] fix panic when fetching consumergroup member assignments

* add changelog entry

* mage fmt

* fix linter

* update new changelog

* fix behaviour in case of sarama error in MemberDescription conversion

* fix linter

* move changelog entry to appropriate version section

* remove entries from  docs/release-notes/index.md

---------

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
(cherry picked from commit 91de405)

# Conflicts:
#	metricbeat/module/kafka/broker_test.go
mergify bot pushed a commit that referenced this pull request Jun 17, 2025
@stefans-elastic @mergify
[metricbeat][kafka] fix panic when fetching consumergroup member assi…
4811c0b 
…gnments (#44576)

* [metricbeat][kafka] fix panic when fetching consumergroup member assignments

* add changelog entry

* mage fmt

* fix linter

* update new changelog

* fix behaviour in case of sarama error in MemberDescription conversion

* fix linter

* move changelog entry to appropriate version section

* remove entries from  docs/release-notes/index.md

---------

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
(cherry picked from commit 91de405)

# Conflicts:
#	metricbeat/module/kafka/broker_test.go
This was referenced Jun 17, 2025
Merged
Merged
Merged
@stefans-elastic stefans-elastic deleted the kafka-panic-fix branch June 17, 2025 14:07
stefans-elastic added a commit that referenced this pull request Jun 18, 2025
@mergify @stefans-elastic
[8.18](backport #44576) [metricbeat][kafka] fix panic when fetching c…
085b4ed 
…onsumergroup member assignments (#44870)

* [metricbeat][kafka] fix panic when fetching consumergroup member assignments (#44576)

* [metricbeat][kafka] fix panic when fetching consumergroup member assignments

* add changelog entry

* mage fmt

* fix linter

* update new changelog

* fix behaviour in case of sarama error in MemberDescription conversion

* fix linter

* move changelog entry to appropriate version section

* remove entries from  docs/release-notes/index.md

---------

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
(cherry picked from commit 91de405)

# Conflicts:
#	metricbeat/module/kafka/broker_test.go

* resolve merge conflicts

---------

Co-authored-by: stefans-elastic <stefan.stas@elastic.co>
stefans-elastic added a commit that referenced this pull request Jun 18, 2025
@mergify @stefans-elastic
[9.0](backport #44576) [metricbeat][kafka] fix panic when fetching co…
e2d3177 
…nsumergroup member assignments (#44872)

* [metricbeat][kafka] fix panic when fetching consumergroup member assignments (#44576)

* [metricbeat][kafka] fix panic when fetching consumergroup member assignments

* add changelog entry

* mage fmt

* fix linter

* update new changelog

* fix behaviour in case of sarama error in MemberDescription conversion

* fix linter

* move changelog entry to appropriate version section

* remove entries from  docs/release-notes/index.md

---------

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
(cherry picked from commit 91de405)

# Conflicts:
#	metricbeat/module/kafka/broker_test.go

* resolve merge conflicts

* remove unrelated changelog entries

---------

Co-authored-by: stefans-elastic <stefan.stas@elastic.co>
stefans-elastic added a commit that referenced this pull request Jun 18, 2025
@mergify @stefans-elastic
[8.19](backport #44576) [metricbeat][kafka] fix panic when fetching c…
91d58de 
…onsumergroup member assignments (#44871)

* [metricbeat][kafka] fix panic when fetching consumergroup member assignments (#44576)

* [metricbeat][kafka] fix panic when fetching consumergroup member assignments

* add changelog entry

* mage fmt

* fix linter

* update new changelog

* fix behaviour in case of sarama error in MemberDescription conversion

* fix linter

* move changelog entry to appropriate version section

* remove entries from  docs/release-notes/index.md

---------

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
(cherry picked from commit 91de405)

# Conflicts:
#	metricbeat/module/kafka/broker_test.go

* resolve merge conflicts

* fix linter errors in metricbeat/module/windows

* fix linter errors in metricbeat/module/windows

* fix missing import

* fix linter errors in metricbeat/module/windows

* fix linter errors in metricbeat/module/windows

* fix linter errors in metricbeat/module/windows

* fix linter errors in metricbeat/module/windows

* fix linter errors in metricbeat/module/windows

---------

Co-authored-by: stefans-elastic <stefan.stas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 left review comments

@colleenmcginnis colleenmcginnis colleenmcginnis left review comments

@ishleenk17 ishleenk17 ishleenk17 approved these changes

@mykola-elastic mykola-elastic mykola-elastic approved these changes

Assignees

@stefans-elastic stefans-elastic

Labels
backport-8.18 Automated backport to the 8.18 branch backport-8.19 Automated backport to the 8.19 branch backport-9.0 Automated backport to the 9.0 branch bug Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in metricbeat with kafka module metric set "consumergroup"
5 participants
@stefans-elastic @ishleenk17 @bmorelli25 @colleenmcginnis @mykola-elastic
0