8000 [9.0](backport #44548) x-pack/filebeat/input/streaming: fix crowdstrike cursor handling by mergify[bot] · Pull Request #44768 · elastic/beats · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[9.0](backport #44548) x-pack/filebeat/input/streaming: fix crowdstrike cursor handling #44768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

[9.0](backport #44548) x-pack/filebeat/input/streaming: fix crowdstrike cursor handling #44768

merged 1 commit into from
Jun 12, 2025

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Jun 12, 2025

Proposed commit message

x-pack/filebeat/input/streaming: fix crowdstrike cursor handling

When the follower is given a non-singular set of resource descriptions,
it incorrectly uses the offset obtained from the registry across all of
the resources, and each of those resources' work loops writes their
cursor updates to the same (incorrectly) shared offset. This results in
cursor offset confusion.

The fix here is to retain cursors for each of the resources, keyed on
the dataFeedURL for each resource.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

This is an automatic backport of pull request #44548 done by [Mergify](https://mergify.com).

@efd6 @mergify
x-pack/filebeat/input/streaming: fix crowdstrike cursor handling (#44548
fd60e85 
)

When the follower is given a non-singular set of resource descriptions,
it incorrectly uses the offset obtained from the registry across all of
the resources, and each of those resources' work loops writes their
cursor updates to the same (incorrectly) shared offset. This results in
cursor offset confusion.

The fix here is to retain cursors for each of the resources, keyed on
the dataFeedURL for each resource.

(cherry picked from commit cdf2355)
@mergify mergify bot added the backport label Jun 12, 2025
@mergify mergify bot requested review from a team as code owners June 12, 2025 03:37
@mergify mergify bot added the backport label Jun 12, 2025
@mergify mergify bot assigned efd6 Jun 12, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 12, 2025
@github-actions github-actions bot added Filebeat Filebeat bugfix Team:Security-Service Integrations Security Service Integrations Team labels Jun 12, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 12, 2025
@efd6 efd6 merged commit 2ed6a64 into 7F04 9.0 Jun 12, 2025
25 of 28 checks passed
@efd6 efd6 deleted the mergify/bp/9.0/pr-44548 branch June 12, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@efd6 efd6

Labels
backport bugfix Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elasticmachine @efd6
0