Finalize 1.0.1 changelog #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
approved these changes
May 24, 2019
CHANGELOG.md
Outdated
|
|
||
| * Fix typo in "process" fieldset definition that prevented the example value for | ||
| `process.pid` from being picked displayed. #464, #470 | ||
|
|
||
| ### Added | ||
|
|
||
| * Add generated source code for Go. #249 |
There was a problem hiding this comment.
I wonder if in the future most of these entries should go into something like "developer changelog" because it does not affect the schema. Would be good to have a place where only changes about the schema are noted.
There was a problem hiding this comment.
Well the example now shows up in the doc. I agree it's not a change to the schema per se, though.
Actually, perhaps the changelog entry should be more straightforward, however:
Add example for
process.pidandprocess.ppid
There was a problem hiding this comment.
My comment was more general and not only for this specific line.
3ec5415 to
d905ed6
Compare
webmat
pushed a commit
to webmat/ecs
that referenced
this pull request
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.