-
Notifications
You must be signed in to change notification settings - Fork 460
[System] Add pipeline for AD FS Auditing to security data stream. #13765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jvalente-salemstate
wants to merge
17
commits into
elastic:main
Choose a base branch
from
jvalente-salemstate:system_security_adfs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[System] Add pipeline for AD FS Auditing to security data stream. #13765
jvalente-salemstate
wants to merge
17
commits into
elastic:main
from
jvalente-salemstate:system_security_adfs
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
Any chance this can be pushed through? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
Integration:system
System
Team:Security-Windows Platform
Security Windows Platform team [elastic/sec-windows-platform]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR adds support for AD FS Auditing (
event.provider: "AD FS Auditing"
) tosystem.security
. These events have anevent.code
of1200-1207
. Most of the information in the event logs is found in an XML object stored inwinlog.event_data.param2
.Rather than trying to parse the XML, I am using the
grok
processor to extract most of this information.Rather than using the script in
standard.yml
, I chose to place an additional painless script processor for ECS categorization within the ADFS pipeline because it seems that these codes may not be exclusive to ADFS. This avoids setting values when not appropriate.event.action
andevent.reason
are set wherever possible.event.code: 1207
has not been tested.Checklist
changelog.yml
file.Related issues
Closes #11539