8000 Add kernel tests and improve testing infrastructure by haesbaert · Pull Request #100 · elastic/quark · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add kernel tests and improve testing infrastructure #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 19, 2024
Merged

Add kernel tests and improve testing infrastructure #100

merged 6 commits into from
Nov 19, 2024

Conversation

haesbaert
Copy link
Collaborator
@haesbaert haesbaert commented Nov 12, 2024 •
edited
Loading

main commit:

    This adds targets `test` `test-kernel` and `test-all` aslong with the scripts
    supporting them `krun.sh` and `ktest-all.sh`.

    `krun.sh` can be used to run a quark utility in a specified kernel:

    $ ./krun.sh initramfs.gz kernel-images/amd64/linux-6.11.4-101.fc39.x86_64 quark-test -v

    `ktest-all.sh` is just a wrapper for running all kernels in kernel-images.

    Keeping the idea of not running scripts directly, these will mostly be used via
    `test-kernel`.

Each commit documents itself, and they won't be squashed.

@haesbaert
Plug a missing build dependency
84ade7f 
libbpf depends on elfdefinitions.h which is generated when we build the
elftoolchain, ideally we would have a target for the headers only, but that's a
lot of work for zero gain, so just make libbpf depend on building the whole
elftoolchain.

Makes it possible to do a clean checkout and run something like
`make quark-test` without doing `make all first`.
@haesbaert
Add test targets and scripts
c59f07a 
This adds targets `test` `test-kernel` and `test-all` along with the scripts
supporting them `krun.sh` and `ktest-all.sh`.

`krun.sh` can be used to run a quark utility in a specified kernel:

$ ./krun.sh initramfs.gz kernel-images/amd64/linux-6.11.4-101.fc39.x86_64 quark-test -v

`ktest-all.sh` is just a wrapper for running all kernels in kernel-images.

Keeping the idea of not running scripts directly, these will mostly be used via
`test-kernel`.
@haesbaert haesbaert changed the title Make test Add kernel tests and improve testing infrastructure Nov 13, 2024
@haesbaert haesbaert marked this pull request as ready for review November 13, 2024 09:14
@haesbaert haesbaert requested a review from a team as a code owner November 13, 2024 09:14
nicholasberlin
nicholasberlin approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor
@nicholasberlin nicholasberlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all three make commands worked for me once I enabled kvm in my VMs.

@haesbaert
Copy link
Collaborator Author

LGTM, all three make commands worked for me once I enabled kvm in my VMs.

Thanks, I removed the kernel commit, I'll see if we can have a better place to stash them, I'm merging the rest.

@haesbaert haesbaert merged commit 242eeff into main Nov 19, 2024
2 checks passed
@haesbaert haesbaert mentioned this pull request Nov 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasberlin nicholasberlin nicholasberlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haesbaert @nicholasberlin
0