8000 chore: multibyte characters path case use nosort by zp1996 · Pull Request #179 · electron/asar · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: multibyte characters path case use nosort #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2019
Merged

chore: multibyte characters path case use nosort #179

merged 1 commit into from
May 28, 2019

Conversation

zp1996
Copy link
Contributor
@zp1996 zp1996 commented May 26, 2019

glob default sort result by function localCompare. Multibyte characters path test case will failed when
the system language is Chinese, so when run this case use nosort?

@malept
Copy link
Member
malept commented May 26, 2019

I think this is a chore rather than a fix, since it only affects tests.

@zp1996 zp1996 changed the title fix: multibyte characters path case use nosort chore: multibyte characters path case use nosort May 27, 2019
@zp1996
Copy link
Contributor Author
zp1996 commented May 27, 2019

I think this is a chore rather than a fix, since it only affects tests.

I have changed the commit msg

@zcbenz zcbenz merged commit 2fa3185 into electron:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zp1996 @malept @zcbenz
0