8000 fix: webview crash on focus by codebytere · Pull Request #46979 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: webview crash on focus #46979

New issue
Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

fix: webview crash on focus #46979

merged 1 commit into from
May 9, 2025

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented May 7, 2025 •
edited by jkleinsc
Loading

Description of Change

Closes #46835
Refs CL:6508949

Fixes an issue where calls to focus in a webView context could crash due to NOTREACHED.

Checklist

Release Notes

Notes: Fixed a possible crash using the WebView tag and calling focus.

@codebytere codebytere requested a review from a team as a code owner May 7, 2025 12:29
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. labels May 7, 2025
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label May 7, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label May 8, 2025
@codebytere codebytere merged commit 8ecd731 into main May 9, 2025
68 checks passed
@release-clerk
Copy link
release-clerk bot commented May 9, 2025

Release Notes Persisted

Fixed a possible crash using the WebView tag and calling focus.

@codebytere codebytere deleted the fix-plock-webview-crash branch May 9, 2025 15:56
This was referenced May 9, 2025
Merged
Merged
Merged
@trop
Copy link
Contributor
trop bot commented May 9, 2025

I have automatically backported this PR to "35-x-y", please check out #47035

@trop trop bot added the in-flight/35-x-y label May 9, 2025
@trop
Copy link
Contributor
trop bot commented May 9, 2025

I have automatically backported this PR to "37-x-y", please check out #47036

@trop trop bot removed the target/35-x-y PR should also be added to the "35-x-y" branch. label May 9, 2025
@trop
Copy link
Contributor
trop bot commented May 9, 2025

I have automatically backported this PR to "36-x-y", please check out #47037

@trop trop bot added in-flight/37-x-y in-flight/36-x-y merged/37-x-y PR was merged to the "37-x-y" branch. and removed target/37-x-y PR should also be added to the "37-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. in-flight/37-x-y in-flight/35-x-y labels May 9, 2025
@trop trop bot added merged/35-x-y PR was merged to the "35-x-y" branch. merged/36-x-y PR was merged to the "36-x-y" branch. and removed in-flight/36-x-y labels May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@ckerr ckerr Awaiting requested review from ckerr

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees
No one assigned
Labels
merged/35-x-y PR was merged to the "35-x-y" branch. merged/36-x-y PR was merged to the "36-x-y" branch. merged/37-x-y PR was merged to the "37-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requesting pointerLock in webview crashes application
2 participants
@codebytere @deepak1556
0