8000 build: migrate to new chromium git auth by jkleinsc · Pull Request #47230 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

build: migrate to new chromium git auth #47230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: migrate to new chromium git auth #47230

wants to merge 1 commit into from
+75 −85

Conversation

jkleinsc
Copy link
Member
@jkleinsc jkleinsc commented May 22, 2025 •
edited
Loading

Description of Change

Chromium is moving away from using a gitcookie to authenticate, eg see https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6367723. This PR moves our chromium git auth to use the new gith auth for chromium.

Checklist

Release Notes

Notes: none

@jkleinsc jkleinsc force-pushed the new-chromium-git-auth branch 2 times, most recently from 6a827a2 to ab14fc5 Compare May 22, 2025 21:28
@jkleinsc jkleinsc added target/34-x-y PR should also be added to the "34-x-y" branch. target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. labels May 22, 2025
@jkleinsc jkleinsc force-pushed the new-chromium-git-auth branch 3 times, most recently from 30e0afd to 50933eb Compare May 23, 2025 13:57
@jkleinsc jkleinsc force-pushed the new-chromium-git-auth branch from d65b168 to cf2990d Compare May 23, 2025 17:53
@jkleinsc jkleinsc marked this pull request as ready for review May 23, 2025 18:01
@jkleinsc jkleinsc requested a review from a team as a code owner May 23, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
semver/none target/34-x-y PR should also be added to the "34-x-y" branch. target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkleinsc @codebytere @VerteDinde
0